From: Fantix King <fantix.king@gmail.com>
Date: Sat, 29 Aug 2020 16:37:34 +0000 (-0400)
Subject: Fix a mis-reference in create_async_engine().
X-Git-Tag: rel_1_4_0b1~135
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9c5b989cf08c3e625fc08a8c5e037c44ba465579;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Fix a mis-reference in create_async_engine().

`AsyncMethodRequired` is actually from
`sqlalchemy.ext.asyncio.exc`, so here it
should be referenced as `async_exc.AsyncMethodRequired`,
instead of `exc.AsyncMethodRequired`.

Fixes: #5529
Closes: #5545
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5545
Pull-request-sha: d8f885c587dd058f909d4f3bdbec3d0fca176680

Change-Id: I6886558bfd33d3e9e283fbd60c0ec971a1f22c0c
---

diff --git a/lib/sqlalchemy/ext/asyncio/engine.py b/lib/sqlalchemy/ext/asyncio/engine.py
index 2d9198d169..619cf85086 100644
--- a/lib/sqlalchemy/ext/asyncio/engine.py
+++ b/lib/sqlalchemy/ext/asyncio/engine.py
@@ -31,7 +31,7 @@ def create_async_engine(*arg, **kw):
     """
 
     if kw.get("server_side_cursors", False):
-        raise exc.AsyncMethodRequired(
+        raise async_exc.AsyncMethodRequired(
             "Can't set server_side_cursors for async engine globally; "
             "use the connection.stream() method for an async "
             "streaming result set"
diff --git a/test/ext/asyncio/test_engine_py3k.py b/test/ext/asyncio/test_engine_py3k.py
index 705df465b4..59c47c4032 100644
--- a/test/ext/asyncio/test_engine_py3k.py
+++ b/test/ext/asyncio/test_engine_py3k.py
@@ -147,6 +147,16 @@ class AsyncEngineTest(EngineFixture):
                 asyncio.TimeoutError, "", engine.connect(),
             )
 
+    @async_test
+    async def test_create_async_engine_server_side_cursor(self, async_engine):
+        testing.assert_raises_message(
+            asyncio_exc.AsyncMethodRequired,
+            "Can't set server_side_cursors for async engine globally",
+            create_async_engine,
+            testing.db.url,
+            server_side_cursors=True,
+        )
+
 
 class AsyncResultTest(EngineFixture):
     @testing.combinations(