From: Bruno E. O. Meneguele Date: Tue, 5 Dec 2017 13:35:32 +0000 (-0200) Subject: ima: log message to module appraisal error X-Git-Tag: v4.16-rc1~129^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9c655be0644429b71396347887b43676ab4f6781;p=thirdparty%2Flinux.git ima: log message to module appraisal error Simple but useful message log to the user in case of module appraise is forced and fails due to the lack of file descriptor, that might be caused by kmod calls to compressed modules. Signed-off-by: Bruno E. O. Meneguele Signed-off-by: Mimi Zohar --- diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c index 0abc7d0db90b9..21330d0455b09 100644 --- a/security/integrity/ima/ima_main.c +++ b/security/integrity/ima/ima_main.c @@ -404,8 +404,10 @@ int ima_read_file(struct file *file, enum kernel_read_file_id read_id) if (!file && read_id == READING_MODULE) { if (!sig_enforce && (ima_appraise & IMA_APPRAISE_MODULES) && - (ima_appraise & IMA_APPRAISE_ENFORCE)) + (ima_appraise & IMA_APPRAISE_ENFORCE)) { + pr_err("impossible to appraise a module without a file descriptor. sig_enforce kernel parameter might help\n"); return -EACCES; /* INTEGRITY_UNKNOWN */ + } return 0; /* We rely on module signature checking */ } return 0;