From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 23 Feb 2017 10:46:27 +0000 (+1300)
Subject: Add missing return statements after self_destruct() in UFS
X-Git-Tag: M-staged-PR71~244
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9c79325e977ed30d7edc6686719c4fce93531589;p=thirdparty%2Fsquid.git

Add missing return statements after self_destruct() in UFS

 Detected by Coverity Scan. Issues 1154222, 1154223.
---

diff --git a/src/fs/ufs/UFSSwapDir.cc b/src/fs/ufs/UFSSwapDir.cc
index 0c6afa57b6..48170703cb 100644
--- a/src/fs/ufs/UFSSwapDir.cc
+++ b/src/fs/ufs/UFSSwapDir.cc
@@ -228,13 +228,17 @@ Fs::Ufs::UFSSwapDir::optionIOParse(char const *option, const char *value, int is
         /* silently ignore this */
         return true;
 
-    if (!value)
+    if (!value) {
         self_destruct();
+        return false;
+    }
 
     DiskIOModule *module = DiskIOModule::Find(value);
 
-    if (!module)
+    if (!module) {
         self_destruct();
+        return false;
+    }
 
     changeIO(module);