From: Alberto Leiva Popper <ydahhrk@gmail.com>
Date: Fri, 2 Jul 2021 23:56:34 +0000 (-0500)
Subject: init: Remove SIGPIPE SIG_IGN override during RTR server startup
X-Git-Tag: v1.5.1~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9c8bb29bbe205a0cb0dc7e3ae7278b045523732e;p=thirdparty%2FFORT-validator.git

init: Remove SIGPIPE SIG_IGN override during RTR server startup

Because it's now redundant.

As discovered in #49, SIGPIPE is total bullshit in all circumstances, no
exceptions, so there's now a global SIGPIPE SIG_IGN override, rendering
this one useless.

I guess we now know why #49 never triggered on server mode.
---

diff --git a/src/rtr/rtr.c b/src/rtr/rtr.c
index 4d39a861..6855c50e 100644
--- a/src/rtr/rtr.c
+++ b/src/rtr/rtr.c
@@ -3,7 +3,6 @@
 #include <errno.h>
 #include <fcntl.h>
 #include <netdb.h>
-#include <signal.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -582,15 +581,8 @@ static int
 start_server_thread(void)
 {
 	struct fd_node *node;
-	struct sigaction ign;
 	int error;
 
-	/* Ignore SIGPIPES, they're handled apart */
-	ign.sa_handler = SIG_IGN;
-	ign.sa_flags = 0;
-	sigemptyset(&ign.sa_mask);
-	sigaction(SIGPIPE, &ign, NULL);
-
 	SLIST_FOREACH(node, &fds, next) {
 		error = listen(node->id, config_get_server_queue());
 		if (error)