From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 11 Apr 2021 15:46:32 +0000 (-0400)
Subject: Fix uninitialized variable from commit a4d75c86b.
X-Git-Tag: REL_14_BETA1~248
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9cb92334092fa75afc62a71243bbc1f4612ecfa4;p=thirdparty%2Fpostgresql.git

Fix uninitialized variable from commit a4d75c86b.

The path for *exprs != NIL would misbehave, and likely crash,
since pull_varattnos expects its last argument to be valid
at call.

Found by Coverity --- we have no coverage of this path in
the regression tests.
---

diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c
index 4674168ff80..4bbd85f401e 100644
--- a/src/backend/statistics/extended_stats.c
+++ b/src/backend/statistics/extended_stats.c
@@ -1609,7 +1609,7 @@ statext_is_compatible_clause(PlannerInfo *root, Node *clause, Index relid,
 
 	if (pg_class_aclcheck(rte->relid, userid, ACL_SELECT) != ACLCHECK_OK)
 	{
-		Bitmapset  *clause_attnums;
+		Bitmapset  *clause_attnums = NULL;
 
 		/* Don't have table privilege, must check individual columns */
 		if (*exprs != NIL)