From: Tom Lane Date: Tue, 26 Sep 2017 19:25:57 +0000 (-0400) Subject: Improve wording of error message added in commit 714805010. X-Git-Tag: REL9_2_24~22 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9d0d0fe57cccc81430930957ab12fa270e5351d2;p=thirdparty%2Fpostgresql.git Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/E1dv9jI-0006oT-Fn@gemulon.postgresql.org --- diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c index f269e23a285..84a99294e50 100644 --- a/src/backend/commands/analyze.c +++ b/src/backend/commands/analyze.c @@ -393,7 +393,7 @@ do_analyze_rel(Relation onerel, VacuumStmt *vacstmt, if (bms_is_member(i, unique_cols)) ereport(ERROR, (errcode(ERRCODE_DUPLICATE_COLUMN), - errmsg("column \"%s\" of relation \"%s\" is specified twice", + errmsg("column \"%s\" of relation \"%s\" appears more than once", col, RelationGetRelationName(onerel)))); unique_cols = bms_add_member(unique_cols, i); diff --git a/src/test/regress/expected/vacuum.out b/src/test/regress/expected/vacuum.out index 6ba8ec93e33..60f6bc2817d 100644 --- a/src/test/regress/expected/vacuum.out +++ b/src/test/regress/expected/vacuum.out @@ -82,8 +82,8 @@ SQL function "wrap_do_analyze" statement 1 VACUUM FULL vactst; -- check behavior with duplicate column mentions VACUUM ANALYZE vaccluster(i,i); -ERROR: column "i" of relation "vaccluster" is specified twice +ERROR: column "i" of relation "vaccluster" appears more than once ANALYZE vaccluster(i,i); -ERROR: column "i" of relation "vaccluster" is specified twice +ERROR: column "i" of relation "vaccluster" appears more than once DROP TABLE vaccluster; DROP TABLE vactst;