From: Richard Henderson <richard.henderson@linaro.org>
Date: Sun, 26 Feb 2023 19:08:09 +0000 (-1000)
Subject: target/ppc: Fix gen_tlbsx_booke206
X-Git-Tag: v8.0.0-rc0~4^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9d15d8e1bbc073d8ac5475562b5afee608ad27ff;p=thirdparty%2Fqemu.git

target/ppc: Fix gen_tlbsx_booke206

Fix incorrect read from rD.
Avoid adding 0 when rA == 0.

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index df324fc7ffd..7ec940b7d80 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -5875,12 +5875,10 @@ static void gen_tlbsx_booke206(DisasContext *ctx)
     CHK_SV(ctx);
     if (rA(ctx->opcode)) {
         t0 = tcg_temp_new();
-        tcg_gen_mov_tl(t0, cpu_gpr[rD(ctx->opcode)]);
+        tcg_gen_add_tl(t0, cpu_gpr[rA(ctx->opcode)], cpu_gpr[rB(ctx->opcode)]);
     } else {
-        t0 = tcg_const_tl(0);
+        t0 = cpu_gpr[rB(ctx->opcode)];
     }
-
-    tcg_gen_add_tl(t0, t0, cpu_gpr[rB(ctx->opcode)]);
     gen_helper_booke206_tlbsx(cpu_env, t0);
 #endif /* defined(CONFIG_USER_ONLY) */
 }