From: Thierry Fournier <tfournier@arpalert.org>
Date: Fri, 19 Feb 2016 17:30:13 +0000 (+0100)
Subject: BUG/MINOR: lua: Useless copy
X-Git-Tag: v1.7-dev2~78
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9d5fb6d6a01331ac3fca3ff16b832697abe6e335;p=thirdparty%2Fhaproxy.git

BUG/MINOR: lua: Useless copy

A value is copied two time in teh stack, but only one is usefull. The
second copy leaves unused in the stack and take some room for noting.

This path removes the second copy.

Must be backported in 1.6
---

diff --git a/src/hlua.c b/src/hlua.c
index fe58b9d0b3..ea800ee398 100644
--- a/src/hlua.c
+++ b/src/hlua.c
@@ -7002,7 +7002,6 @@ void hlua_init(void)
 
 	/* Register previous table in the registry with reference and named entry. */
 	lua_pushvalue(gL.T, -1); /* Copy the -1 entry and push it on the stack. */
-	lua_pushvalue(gL.T, -1); /* Copy the -1 entry and push it on the stack. */
 	lua_setfield(gL.T, LUA_REGISTRYINDEX, CLASS_SOCKET); /* register class socket. */
 	class_socket_ref = luaL_ref(gL.T, LUA_REGISTRYINDEX); /* reference class socket. */