From: Pauli <ppzgs1@gmail.com>
Date: Sun, 21 Mar 2021 22:47:58 +0000 (+1000)
Subject: dh: fix coverty 1474423: resource leak
X-Git-Tag: openssl-3.0.0-alpha14~156
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9d8c53ed164f325a28bee657b09cf4b30d62a08f;p=thirdparty%2Fopenssl.git

dh: fix coverty 1474423: resource leak

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14637)
---

diff --git a/crypto/dh/dh_backend.c b/crypto/dh/dh_backend.c
index 8da830f9d8e..97f5271a5ad 100644
--- a/crypto/dh/dh_backend.c
+++ b/crypto/dh/dh_backend.c
@@ -161,6 +161,7 @@ DH *ossl_dh_key_from_pkcs8(const PKCS8_PRIV_KEY_INFO *p8inf,
     if ((privkey_bn = BN_secure_new()) == NULL
         || !ASN1_INTEGER_to_BN(privkey, privkey_bn)) {
         ERR_raise(ERR_LIB_DH, DH_R_BN_ERROR);
+        BN_clear_free(privkey_bn);
         goto dherr;
     }
     if (!DH_set0_key(dh, NULL, privkey_bn))