From: Lucas De Marchi <lucas.demarchi@intel.com>
Date: Tue, 15 Feb 2022 22:05:13 +0000 (-0800)
Subject: test-initstate: Check for negative value on error
X-Git-Tag: v30~30
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9dc4e5ccd4d7ff9ed4e96db8446501a3dc862dbf;p=thirdparty%2Fkmod.git

test-initstate: Check for negative value on error

Documentation says kmod_module_new_from_lookup() returns < 0 on error
and 0 otherwise. There are bugs in libkmod however making it return
a positive value in some situations, that need to be fixed. However
it's best to check for the error explicitly like is done in the rest
of the library to avoid this kind of issues.

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
---

diff --git a/testsuite/test-initstate.c b/testsuite/test-initstate.c
index da2303a1..9332e8f2 100644
--- a/testsuite/test-initstate.c
+++ b/testsuite/test-initstate.c
@@ -45,7 +45,7 @@ static noreturn int test_initstate_from_lookup(const struct test *t)
 		exit(EXIT_FAILURE);
 
 	err = kmod_module_new_from_lookup(ctx, "fake-builtin", &list);
-	if (err != 0) {
+	if (err < 0) {
 		ERR("could not create module from lookup: %s\n", strerror(-err));
 		exit(EXIT_FAILURE);
 	}