From: Thomas Markwalder <tmark@isc.org>
Date: Wed, 23 Jul 2025 18:19:51 +0000 (-0400)
Subject: [#3770] Minor correction to hash input value.
X-Git-Tag: Kea-3.1.0~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9dfad9bb0beca9e9e1fd5b9aaecaeac138a017a5;p=thirdparty%2Fkea.git

[#3770] Minor correction to hash input value.

Use non-empy delimiter.

modified:   ../classify.cc
modified:   classify_unittest.cc
---

diff --git a/src/lib/dhcp/classify.cc b/src/lib/dhcp/classify.cc
index 543b81d99f..3c63ddfca4 100644
--- a/src/lib/dhcp/classify.cc
+++ b/src/lib/dhcp/classify.cc
@@ -141,7 +141,7 @@ ClientClasses::Hash::operator()(const ClientClasses &client_classes) {
 
 size_t hash_value(const ClientClasses& client_classes) {
     boost::hash<std::string> hasher;
-    return (hasher(client_classes.toText("")));
+    return (hasher(client_classes.toText("+")));
 }
 
 }} // end of namespace isc
diff --git a/src/lib/dhcp/tests/classify_unittest.cc b/src/lib/dhcp/tests/classify_unittest.cc
index 64c68064fe..6253167c91 100644
--- a/src/lib/dhcp/tests/classify_unittest.cc
+++ b/src/lib/dhcp/tests/classify_unittest.cc
@@ -322,10 +322,16 @@ TEST(ClassifyTest, ClientClassesHash) {
     ClientClasses cclasses2(cclasses);
     EXPECT_EQ(hash(cclasses2), hash(cclasses));
 
-    // Check that different ordering make not equal hashes.
+    // Check that different ordering makes not equal hashes.
     ClientClasses cclasses3;
     cclasses3.insert("three");
     cclasses3.insert("two");
     cclasses3.insert("one");
     EXPECT_NE(hash(cclasses3), hash(cclasses));
+
+    // Check that single class name same as individual class names
+    // makes not equal hashes.
+    ClientClasses cclasses4;
+    cclasses4.insert("onetwothree");
+    EXPECT_NE(hash(cclasses4), hash(cclasses));
 }