From: Eric Covener <covener@apache.org>
Date: Sun, 19 Aug 2007 23:19:46 +0000 (+0000)
Subject: backport mod_ldap shared memory lock fix
X-Git-Tag: 2.2.6~144
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9e0f86ad649ea949d64344b984f1b847128b86bf;p=thirdparty%2Fapache%2Fhttpd.git

backport mod_ldap shared memory lock fix


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@567506 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/CHANGES b/CHANGES
index bd178f3a240..7eb85f76bf7 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,9 @@
                                                         -*- coding: utf-8 -*-
 Changes with Apache 2.2.6
 
+  *) mod_ldap: Avoid possible crashes, hangs, and busy loops due to
+     improper merging of the cache lock in vhost config
+     PR 43164 [Eric Covener]
 
 Changes with Apache 2.2.5
 
diff --git a/STATUS b/STATUS
index 9ae0a4b0970..31e249ae89b 100644
--- a/STATUS
+++ b/STATUS
@@ -78,11 +78,6 @@ RELEASE SHOWSTOPPERS:
 PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
   [ start all new proposals below, under PATCHES PROPOSED. ]
 
-    * mod_ldap: Copy cache lock into per-server config
-      http://svn.apache.org/viewvc?view=rev&revision=567091
-      +1: covener, trawick (iff CHANGES is modified to mention the 
-          severe problem symptoms caused by not grabbing mutex)
-      rpluem says: Dito to trawick: +1 iff CHANGES is modified accordingly.
 
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
 
diff --git a/modules/ldap/util_ldap.c b/modules/ldap/util_ldap.c
index 9783a77b83e..d6f8c78bc10 100644
--- a/modules/ldap/util_ldap.c
+++ b/modules/ldap/util_ldap.c
@@ -1823,6 +1823,7 @@ static void *util_ldap_merge_config(apr_pool_t *p, void *basev,
     st->search_cache_size = base->search_cache_size;
     st->compare_cache_ttl = base->compare_cache_ttl;
     st->compare_cache_size = base->compare_cache_size;
+    st->util_ldap_cache_lock = base->util_ldap_cache_lock; 
 
     st->connections = NULL;
     st->ssl_supported = 0;