From: Aki Tuomi <aki.tuomi@open-xchange.com>
Date: Mon, 2 Sep 2019 11:09:04 +0000 (+0300)
Subject: lib-ssl-iostream: Remove problematic unit tests
X-Git-Tag: 2.3.9~229
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9e2cc03343097cb34e9d4eb124f8d4d526128dc7;p=thirdparty%2Fdovecot%2Fcore.git

lib-ssl-iostream: Remove problematic unit tests

These unit tests are unreliable with new versions of openssl
present in ubuntu 18 and debian buster.
---

diff --git a/src/lib-ssl-iostream/test-iostream-ssl.c b/src/lib-ssl-iostream/test-iostream-ssl.c
index a87c97f7c2..2d1f4dbbec 100644
--- a/src/lib-ssl-iostream/test-iostream-ssl.c
+++ b/src/lib-ssl-iostream/test-iostream-ssl.c
@@ -322,30 +322,6 @@ static void test_iostream_ssl_handshake(void)
 							 "failhost") != 0, idx);
 	idx++;
 
-	/* mismatch in cipher list */
-	ssl_iostream_test_settings_server(&server_set);
-	ssl_iostream_test_settings_client(&client_set);
-	server_set.cipher_list = "ECDSA";
-	client_set.cipher_list = "RSA";
-	server_set.ciphersuites = "TLS_CHACHA20_POLY1305_SHA256";
-	client_set.ciphersuites = "TLS_AES_128_CCM_SHA256";
-	client_set.prefer_server_ciphers = TRUE;
-	client_set.verify_remote_cert = TRUE;
-	test_expect_error_string("client(127.0.0.1): SSL certificate not received");
-	test_assert_idx(test_iostream_ssl_handshake_real(&server_set, &client_set,
-							 "127.0.0.1") != 0, idx);
-	idx++;
-
-	/* unsupported cipher list */
-	ssl_iostream_test_settings_server(&server_set);
-	ssl_iostream_test_settings_client(&client_set);
-	server_set.cipher_list = "NONEXISTENT";
-	client_set.prefer_server_ciphers = TRUE;
-	test_expect_error_string("server: Can't set cipher list to 'NONEXISTENT'");
-	test_assert_idx(test_iostream_ssl_handshake_real(&server_set, &client_set,
-							 "127.0.0.1") != 0, idx);
-	idx++;
-
 	/* invalid client credentials: missing credentials */
 	ssl_iostream_test_settings_server(&server_set);
 	ssl_iostream_test_settings_client(&client_set);