From: Sasha Levin Date: Thu, 7 Jan 2021 14:21:48 +0000 (-0500) Subject: Fixes for 4.4 X-Git-Tag: v4.4.250~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9e5939a8cd24c8572de4ffc6fa65feb7e8422a6a;p=thirdparty%2Fkernel%2Fstable-queue.git Fixes for 4.4 Signed-off-by: Sasha Levin --- diff --git a/queue-4.4/mwifiex-fix-possible-buffer-overflows-in-mwifiex_cmd.patch b/queue-4.4/mwifiex-fix-possible-buffer-overflows-in-mwifiex_cmd.patch new file mode 100644 index 00000000000..2d4ca169e07 --- /dev/null +++ b/queue-4.4/mwifiex-fix-possible-buffer-overflows-in-mwifiex_cmd.patch @@ -0,0 +1,40 @@ +From 659e2a827152dc817e85c6914ba17cc80f080918 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 6 Dec 2020 16:48:01 +0800 +Subject: mwifiex: Fix possible buffer overflows in + mwifiex_cmd_802_11_ad_hoc_start + +From: Zhang Xiaohui + +[ Upstream commit 5c455c5ab332773464d02ba17015acdca198f03d ] + +mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking +the destination size may trigger a buffer overflower, +which a local user could use to cause denial of service +or the execution of arbitrary code. +Fix it by putting the length check before calling memcpy(). + +Signed-off-by: Zhang Xiaohui +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20201206084801.26479-1-ruc_zhangxiaohui@163.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/mwifiex/join.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/net/wireless/mwifiex/join.c b/drivers/net/wireless/mwifiex/join.c +index 6378dfd3b4e86..83b7cd5bdf930 100644 +--- a/drivers/net/wireless/mwifiex/join.c ++++ b/drivers/net/wireless/mwifiex/join.c +@@ -856,6 +856,8 @@ mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv, + + memset(adhoc_start->ssid, 0, IEEE80211_MAX_SSID_LEN); + ++ if (req_ssid->ssid_len > IEEE80211_MAX_SSID_LEN) ++ req_ssid->ssid_len = IEEE80211_MAX_SSID_LEN; + memcpy(adhoc_start->ssid, req_ssid->ssid, req_ssid->ssid_len); + + mwifiex_dbg(adapter, INFO, "info: ADHOC_S_CMD: SSID = %s\n", +-- +2.27.0 + diff --git a/queue-4.4/series b/queue-4.4/series index b0bfdeae8da..fad8d2f3baa 100644 --- a/queue-4.4/series +++ b/queue-4.4/series @@ -17,3 +17,4 @@ quota-don-t-overflow-quota-file-offsets.patch powerpc-sysdev-add-missing-iounmap-on-error-in-mpic_.patch module-delay-kobject-uevent-until-after-module-init-.patch iio-magnetometer-mag3110-fix-alignment-and-data-leak-issues.patch +mwifiex-fix-possible-buffer-overflows-in-mwifiex_cmd.patch