From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Wed, 27 Aug 2025 10:22:48 +0000 (+0200)
Subject: sys_linux: improve error message for failed PHC open
X-Git-Tag: 4.8^0
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9e8541e3c4c89bfb7a60b404f646fab57c69ce59;p=thirdparty%2Fchrony.git

sys_linux: improve error message for failed PHC open

If the specified PHC device cannot be opened directly, an attempt is
made to open it as a network interface. When that fails, the error
"Could not open PHC of iface" is misleading the user that it was handled
only as an interface. Change the message to "Could not open PHC (of)" to
better cover both possibilities. Also remove the errno as it's not set
in all code paths.
---

diff --git a/sys_linux.c b/sys_linux.c
index 53c49a89..ca5540f2 100644
--- a/sys_linux.c
+++ b/sys_linux.c
@@ -944,8 +944,7 @@ SYS_Linux_OpenPHC(const char *device, int flags)
   if (phc_fd < 0) {
     phc_fd = open_phc_by_iface_name(device, flags);
     if (phc_fd < 0) {
-      LOG(LOGS_ERR, "Could not open PHC of iface %s : %s",
-          device, strerror(errno));
+      LOG(LOGS_ERR, "Could not open PHC (of) %s", device);
       return -1;
     }
     phc_fd = verify_fd_is_phc(phc_fd);