From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 10 Dec 2018 15:38:49 +0000 (-0500)
Subject: Make TupleDescInitBuiltinEntry throw error for unsupported types.
X-Git-Tag: REL_10_7~90
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9eaba23c414d9da1e767e1af0a80cb687dc358e2;p=thirdparty%2Fpostgresql.git

Make TupleDescInitBuiltinEntry throw error for unsupported types.

Previously, it would just pass back a partially-uninitialized tupdesc,
which doesn't seem like a safe or useful behavior.

Backpatch to v10 where this code came in.

Discussion: https://postgr.es/m/30830.1544384975@sss.pgh.pa.us
---

diff --git a/src/backend/access/common/tupdesc.c b/src/backend/access/common/tupdesc.c
index 9fd7b4e019b..129176f6b71 100644
--- a/src/backend/access/common/tupdesc.c
+++ b/src/backend/access/common/tupdesc.c
@@ -643,6 +643,9 @@ TupleDescInitBuiltinEntry(TupleDesc desc,
 			att->attstorage = 'p';
 			att->attcollation = InvalidOid;
 			break;
+
+		default:
+			elog(ERROR, "unsupported type %u", oidtypeid);
 	}
 }