From: Kent Gibson <warthog618@gmail.com>
Date: Sun, 20 Oct 2024 11:52:38 +0000 (+0800)
Subject: gpiolib: cdev: remove redundant store of debounce_period_us
X-Git-Tag: v6.13-rc1~156^2~40
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9eb1e8276155b9f540281f2dbf59885efbb9f09f;p=thirdparty%2Fkernel%2Flinux.git

gpiolib: cdev: remove redundant store of debounce_period_us

debounce_setup() stores the debounce_period_us if the driver supports
debounce, but the debounce_period_us is also stored where debounce_setup()
is called, independent of whether the debounce is being perfomed by
hardware or software.

Remove the redundant storing of the debounce_period_us in
debounce_setup().

Signed-off-by: Kent Gibson <warthog618@gmail.com>
Link: https://lore.kernel.org/r/20241020115238.170994-1-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---

diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index 13d83675bf4f8..0ec162b0ea042 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -929,10 +929,6 @@ static int debounce_setup(struct line *line, unsigned int debounce_period_us)
 	ret = gpio_do_set_config(line->desc,
 			pinconf_to_config_packed(PIN_CONFIG_INPUT_DEBOUNCE,
 						 debounce_period_us));
-	if (!ret) {
-		WRITE_ONCE(line->desc->debounce_period_us, debounce_period_us);
-		return ret;
-	}
 	if (ret != -ENOTSUPP)
 		return ret;