From: Eduardo San Martin Morote <posva13@gmail.com>
Date: Thu, 12 Aug 2021 16:55:31 +0000 (+0200)
Subject: chore: improve message
X-Git-Tag: @pinia/nuxt@0.0.1~52
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9f435ac252cfab656c2e82ce503fdd140a8b96bf;p=thirdparty%2Fvuejs%2Fpinia.git

chore: improve message
---

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index a7761bd8..4ebd805a 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,36 +1,4 @@
 <!--
-Please make sure to read the Pull Request Guidelines:
-https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#Pull-Request
+Please make sure to include a test! If this is closing an
+existing issue, reference that issue as well.
 -->
-
-<!-- PULL REQUEST TEMPLATE -->
-<!-- (Update "[ ]" to "[x]" to check a box) -->
-<!-- Tip: publish the PR and check the checkboxes by simply clicking on them -->
-
-**What kind of change does this PR introduce?** (check at least one)
-
-- [ ] Bugfix
-- [ ] Feature
-- [ ] Code style update
-- [ ] Refactor
-- [ ] Build-related changes
-- [ ] Other, please describe:
-
-**Does this PR introduce a breaking change?** (check one)
-
-- [ ] Yes
-- [ ] No
-
-If yes, please describe the impact and migration path for existing applications:
-
-**The PR fulfills these requirements:**
-
-- [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
-- [ ] All tests are passing
-- [ ] New/updated tests are included
-
-If adding a **new feature**, the PR's description includes:
-
-- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
-
-**Other information:**
diff --git a/src/store.ts b/src/store.ts
index 691ca1e8..684c3027 100644
--- a/src/store.ts
+++ b/src/store.ts
@@ -409,15 +409,17 @@ function createSetupStore<
     $patch,
     $reset,
     $subscribe(callback, options = {}) {
+      /* istanbul ignore if */
       if (__DEV__ && typeof options === 'boolean') {
         console.warn(
           `[🍍]: store.$subscribe() no longer accepts a boolean as the 2nd parameter:\n` +
             `Replace "store.$subscribe(fn, ${String(
               options
-            )})" with "$store.$subscribe(fn, { detached: ${String(
+            )})" with "store.$subscribe(fn, { detached: ${String(
               options
-            )} })".`
+            )} })".\n This will fail in production.`
         )
+        options = { detached: options }
       }
 
       const _removeSubscription = addSubscription(