From: Martin Matuska <martin@matuska.org>
Date: Thu, 16 Jan 2020 23:31:07 +0000 (+0100)
Subject: archive_read.c: remove unnecessary comparsion (iindex is unsigned int)
X-Git-Tag: v3.4.2~38
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9f67e742b55e83b10b3dcf2df263c6bf43970e91;p=thirdparty%2Flibarchive.git

archive_read.c: remove unnecessary comparsion (iindex is unsigned int)

Found by LGTM.com code analysis
---

diff --git a/libarchive/archive_read.c b/libarchive/archive_read.c
index 587260110..4a933b2fc 100644
--- a/libarchive/archive_read.c
+++ b/libarchive/archive_read.c
@@ -433,7 +433,7 @@ archive_read_add_callback_data(struct archive *_a, void *client_data,
 		return ARCHIVE_FATAL;
 	}
 	a->client.dataset = (struct archive_read_data_node *)p;
-	for (i = a->client.nodes - 1; i > iindex && i > 0; i--) {
+	for (i = a->client.nodes - 1; i > iindex; i--) {
 		a->client.dataset[i].data = a->client.dataset[i-1].data;
 		a->client.dataset[i].begin_position = -1;
 		a->client.dataset[i].total_size = -1;