From: Willy Tarreau <w@1wt.eu>
Date: Tue, 8 Sep 2015 14:01:25 +0000 (+0200)
Subject: BUG/MINOR: tools: make str2sa_range() report unresolvable addresses
X-Git-Tag: v1.6-dev5~11
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9f69f46d1f1b1d116c00b4b0483c519747f977b7;p=thirdparty%2Fhaproxy.git

BUG/MINOR: tools: make str2sa_range() report unresolvable addresses

If an environment variable is used in an address, and is not set, it's
silently considered as ":" or "0.0.0.0:0" which is not correct as it
can hide environment issues and lead to unexpected behaviours. Let's
report this case when it happens.

This fix should be backported to 1.5.
---

diff --git a/src/standard.c b/src/standard.c
index 58cc5deb43..7964b88ddb 100644
--- a/src/standard.c
+++ b/src/standard.c
@@ -782,6 +782,11 @@ struct sockaddr_storage *str2sa_range(const char *str, int *low, int *high, char
 		goto out;
 	}
 
+	if (!*str2) {
+		memprintf(err, "'%s' resolves to an empty address (environment variable missing?)\n", str);
+		goto out;
+	}
+
 	memset(&ss, 0, sizeof(ss));
 
 	if (strncmp(str2, "unix@", 5) == 0) {