From: Cyril Bonté <cyril.bonte@free.fr>
Date: Thu, 14 Dec 2017 21:44:41 +0000 (+0100)
Subject: BUG: MINOR: http: don't check http-request capture id when len is provided
X-Git-Tag: v1.9-dev1~578
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9fc9e53763f0bda431879ceaef3968bf1f43509e;p=thirdparty%2Fhaproxy.git

BUG: MINOR: http: don't check http-request capture id when len is provided

Randomly, haproxy could fail to start when a "http-request capture"
action is defined, without any change to the configuration. The issue
depends on the memory content, which may raise a fatal error like :
  unable to find capture id 'xxxx' referenced by http-request capture
rule

Commit fd608dd2 already prevents the condition to happen, but this one
should be included for completeness and to reclect the code on the
response side.

The issue was introduced recently by commit 29730ba5 and should only be
backported to haproxy 1.8.
---

diff --git a/src/proto_http.c b/src/proto_http.c
index 1330ac8648..481688fdf6 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -12149,7 +12149,6 @@ enum act_parse_ret parse_http_req_capture(const char **args, int *orig_arg, stru
 
 		rule->action       = ACT_CUSTOM;
 		rule->action_ptr   = http_action_req_capture;
-		rule->check_ptr    = check_http_req_capture;
 		rule->arg.cap.expr = expr;
 		rule->arg.cap.hdr  = hdr;
 	}