From: Michael Tremer <michael.tremer@ipfire.org>
Date: Sat, 1 Jul 2023 09:08:48 +0000 (+0000)
Subject: virt: Fix off-by-one error when detecting hypervisor
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=HEAD;p=oddments%2Ffireinfo.git

virt: Fix off-by-one error when detecting hypervisor

Reported-by: Mauro Condarelli <mc5686@mclink.it>
Fixes: #13155 - _fireinfo.detect_hypervisor() rises Segmentation fault
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/_fireinfo/fireinfo.c b/src/_fireinfo/fireinfo.c
index 1d3f424..18edf34 100644
--- a/src/_fireinfo/fireinfo.c
+++ b/src/_fireinfo/fireinfo.c
@@ -32,8 +32,8 @@ enum hypervisors {
 	HYPER_KVM,
 	HYPER_MSHV,
 	HYPER_VMWARE,
+	// Must always be last
 	HYPER_OTHER,
-	HYPER_LAST /* for loop - must be last*/
 };
 
 const char *hypervisor_ids[] = {
@@ -157,7 +157,7 @@ int detect_hypervisor(int *hypervisor) {
 		*hypervisor = HYPER_OTHER;
 
 		if (*sig.text) {
-			for (int id = HYPER_NONE + 1; id < HYPER_LAST; id++) {
+			for (int id = HYPER_NONE + 1; id < HYPER_OTHER; id++) {
 				if (strcmp(hypervisor_ids[id], sig.text) == 0) {
 					*hypervisor = id;
 					break;