From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 22 Aug 2025 12:38:03 +0000 (+0200)
Subject: dnsdist: Apply Miod's suggestion
X-Git-Tag: dnsdist-1.9.11~1^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a00363235840b23a878cfea3aaf4feb4ef73b465;p=thirdparty%2Fpdns.git

dnsdist: Apply Miod's suggestion

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Remi Gacogne <github@coredump.fr>
(cherry picked from commit 0cf2668a8c625f72944f682010befbe3089b9dd0)
---

diff --git a/pdns/dnsdistdist/dnsdist-nghttp2-in.cc b/pdns/dnsdistdist/dnsdist-nghttp2-in.cc
index b200c9adb..2681d880d 100644
--- a/pdns/dnsdistdist/dnsdist-nghttp2-in.cc
+++ b/pdns/dnsdistdist/dnsdist-nghttp2-in.cc
@@ -549,7 +549,7 @@ static const std::string s_xForwardedForHeaderName("x-forwarded-for");
 
 static void addHeader(std::vector<nghttp2_nv>& headers, const std::string_view& name, bool nameIsStatic, const std::string_view& value, bool valueIsStatic)
 {
-  /* Be careful when setting NGHTTP2_NV_FLAG_NO_COPY_NAME or NGHTTP2_NV_FLAG_NO_COPY_VALUE, the corresponding name or value needs to exist until after nghttp2_session_send() has been called, not just nghttp2_submit_response */
+  /* Be careful when setting NGHTTP2_NV_FLAG_NO_COPY_NAME or NGHTTP2_NV_FLAG_NO_COPY_VALUE, the corresponding name or value needs to exist until after nghttp2_session_send() has been called, not just nghttp2_submit_response(). */
   uint8_t flag{NGHTTP2_NV_FLAG_NONE};
   if (nameIsStatic) {
     flag |= NGHTTP2_NV_FLAG_NO_COPY_NAME;