From: Daniel Golle Date: Thu, 2 Jan 2025 12:41:21 +0000 (+0000) Subject: net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities X-Git-Tag: v6.14-rc1~162^2~145 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a003c38d9bbbacd26b2354795bddb8d25631b0b5;p=thirdparty%2Fkernel%2Flinux.git net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities Neither does the LynxI PCS support QSGMII, nor is in-band-status supported in 2500Base-X mode. Fix the pcs_inband_caps() method accordingly. Fixes: 520d29bdda86 ("net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method") Signed-off-by: Daniel Golle Link: https://patch.msgid.link/Z3aJccb1vW14aukg@pidgin.makrotopia.org Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c index 7de8045352298..ed91cd7a406ae 100644 --- a/drivers/net/pcs/pcs-mtk-lynxi.c +++ b/drivers/net/pcs/pcs-mtk-lynxi.c @@ -93,11 +93,12 @@ static unsigned int mtk_pcs_lynxi_inband_caps(struct phylink_pcs *pcs, { switch (interface) { case PHY_INTERFACE_MODE_1000BASEX: - case PHY_INTERFACE_MODE_2500BASEX: case PHY_INTERFACE_MODE_SGMII: - case PHY_INTERFACE_MODE_QSGMII: return LINK_INBAND_DISABLE | LINK_INBAND_ENABLE; + case PHY_INTERFACE_MODE_2500BASEX: + return LINK_INBAND_DISABLE; + default: return 0; }