From: Kai Mäkisara <Kai.Makisara@kolumbus.fi>
Date: Tue, 11 Mar 2025 11:25:14 +0000 (+0200)
Subject: scsi: st: Fix array overflow in st_setup()
X-Git-Tag: v6.15-rc1~164^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a018d1cf990d0c339fe0e29b762ea5dc10567d67;p=thirdparty%2Flinux.git

scsi: st: Fix array overflow in st_setup()

Change the array size to follow parms size instead of a fixed value.

Reported-by: Chenyuan Yang <chenyuan0y@gmail.com>
Closes: https://lore.kernel.org/linux-scsi/CALGdzuoubbra4xKOJcsyThdk5Y1BrAmZs==wbqjbkAgmKS39Aw@mail.gmail.com/
Signed-off-by: Kai Mäkisara <Kai.Makisara@kolumbus.fi>
Link: https://lore.kernel.org/r/20250311112516.5548-2-Kai.Makisara@kolumbus.fi
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 85867120c8a9e..756b7c8623181 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4157,7 +4157,7 @@ static void validate_options(void)
  */
 static int __init st_setup(char *str)
 {
-	int i, len, ints[5];
+	int i, len, ints[ARRAY_SIZE(parms) + 1];
 	char *stp;
 
 	stp = get_options(str, ARRAY_SIZE(ints), ints);