From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 4 Oct 2021 11:42:54 +0000 (+0300)
Subject: lib: buffer_free() - Check for buf==NULL before using container_of()
X-Git-Tag: 2.3.18~259
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a037ede37f97729665387cdec0018314ecfdedb3;p=thirdparty%2Fdovecot%2Fcore.git

lib: buffer_free() - Check for buf==NULL before using container_of()

Helps with static analyzer complaints.
---

diff --git a/src/lib/buffer.c b/src/lib/buffer.c
index 55f230b321..f6f3a0f9ec 100644
--- a/src/lib/buffer.c
+++ b/src/lib/buffer.c
@@ -184,10 +184,9 @@ buffer_t *buffer_create_dynamic_max(pool_t pool, size_t init_size,
 
 void buffer_free(buffer_t **_buf)
 {
-	struct real_buffer *buf = container_of(*_buf, struct real_buffer, buf);
-
-	if (buf == NULL)
+	if (*_buf == NULL)
 		return;
+	struct real_buffer *buf = container_of(*_buf, struct real_buffer, buf);
 
 	*_buf = NULL;
 	if (buf->alloced)