From: Ryan Harper <ryanh@us.ibm.com>
Date: Mon, 7 Mar 2011 16:01:04 +0000 (-0600)
Subject: Don't allow multiwrites against a block device without underlying medium
X-Git-Tag: v0.14.1~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a0af597d00c27741a0bf99720209def055f45499;p=thirdparty%2Fqemu.git

Don't allow multiwrites against a block device without underlying medium

If the block device has been closed, we no longer have a medium to submit
IO against, check for this before submitting io.  This prevents a segfault
further in the code where we dereference elements of the block driver.

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/block.c b/block.c
index b476479e0dc..17de165a5bd 100644
--- a/block.c
+++ b/block.c
@@ -2295,6 +2295,14 @@ int bdrv_aio_multiwrite(BlockDriverState *bs, BlockRequest *reqs, int num_reqs)
     MultiwriteCB *mcb;
     int i;
 
+    /* don't submit writes if we don't have a medium */
+    if (bs->drv == NULL) {
+        for (i = 0; i < num_reqs; i++) {
+            reqs[i].error = -ENOMEDIUM;
+        }
+        return -1;
+    }
+
     if (num_reqs == 0) {
         return 0;
     }