From: Gustavo A. R. Silva <gustavo@embeddedor.com>
Date: Wed, 9 Aug 2017 16:16:03 +0000 (-0500)
Subject: PCI: dra7xx: Propagate platform_get_irq() errors in dra7xx_pcie_probe()
X-Git-Tag: v4.14-rc1~87^2~31^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a0d21ba120d2c7daae847633bb59a3c3375cc1d7;p=thirdparty%2Fkernel%2Flinux.git

PCI: dra7xx: Propagate platform_get_irq() errors in dra7xx_pcie_probe()

platform_get_irq() returns an error code, but the pci-dra7xx driver ignores
it and always returns -EINVAL. This is not correct and prevents
-EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq() on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
---

diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index 30131ecaadeae..34d86896694a1 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(dev, "missing IRQ resource\n");
-		return -EINVAL;
+		dev_err(dev, "missing IRQ resource: %d\n", irq);
+		return irq;
 	}
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf");