From: Will Deacon <will.deacon@arm.com>
Date: Fri, 4 Dec 2015 12:00:29 +0000 (+0000)
Subject: iommu/arm-smmu: Handle unknown CERROR values gracefully
X-Git-Tag: v4.5-rc1~61^2^6^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a0d5c04c6053d8c47cca37384ae472f6b2ee0dee;p=thirdparty%2Fkernel%2Flinux.git

iommu/arm-smmu: Handle unknown CERROR values gracefully

Whilst the architecture only defines a few of the possible CERROR values,
we should handle unknown values gracefully rather than go out of bounds
trying to print out an error description.

Signed-off-by: Will Deacon <will.deacon@arm.com>
---

diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
index 3ea4d576bf087..4c5ef4e5da98e 100644
--- a/drivers/iommu/arm-smmu-v3.c
+++ b/drivers/iommu/arm-smmu-v3.c
@@ -857,15 +857,17 @@ static void arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu)
 	};
 
 	dev_err(smmu->dev, "CMDQ error (cons 0x%08x): %s\n", cons,
-		cerror_str[idx]);
+		idx < ARRAY_SIZE(cerror_str) ?  cerror_str[idx] : "Unknown");
 
 	switch (idx) {
-	case CMDQ_ERR_CERROR_ILL_IDX:
-		break;
 	case CMDQ_ERR_CERROR_ABT_IDX:
 		dev_err(smmu->dev, "retrying command fetch\n");
 	case CMDQ_ERR_CERROR_NONE_IDX:
 		return;
+	case CMDQ_ERR_CERROR_ILL_IDX:
+		/* Fallthrough */
+	default:
+		break;
 	}
 
 	/*