From: Willy Tarreau <w@1wt.eu>
Date: Wed, 29 Apr 2020 09:50:38 +0000 (+0200)
Subject: BUG/MEDIUM: http: the "unique-id" sample fetch could crash without a steeam
X-Git-Tag: v2.2-dev7~50
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a1062a4de8ba300979cc380b69b284f86dc13853;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: http: the "unique-id" sample fetch could crash without a steeam

Since commit 5f940703b3 ("MINOR: log: Don't depends on a stream to process
samples in log-format string") it has become quite obvious that a few sample
fetch functions and converters were still heavily dependent on the presence
of a stream without testing for it.

The unique-id sample fetch function, if called without a stream, will result
in a crash.

This fix adds a check for the stream's existence, and should be backported
to all stable versions up to 1.7.
---

diff --git a/src/http_fetch.c b/src/http_fetch.c
index 11c1c5ab02..765c4458f4 100644
--- a/src/http_fetch.c
+++ b/src/http_fetch.c
@@ -414,6 +414,9 @@ static int smp_fetch_uniqueid(const struct arg *args, struct sample *smp, const
 	if (LIST_ISEMPTY(&smp->sess->fe->format_unique_id))
 		return 0;
 
+	if (!smp->strm)
+		return 0;
+
 	unique_id = stream_generate_unique_id(smp->strm, &smp->sess->fe->format_unique_id);
 	if (!isttest(unique_id))
 		return 0;