From: Greg Kroah-Hartman Date: Sat, 27 Nov 2021 13:12:32 +0000 (+0100) Subject: 5.4-stable patches X-Git-Tag: v5.15.6~69 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a12a0f009c36abc3ae9353de116407da748f9fff;p=thirdparty%2Fkernel%2Fstable-queue.git 5.4-stable patches added patches: alsa-ctxfi-fix-out-of-range-access.patch binder-fix-test-regression-due-to-sender_euid-change.patch hid-wacom-use-confidence-flag-to-prevent-reporting-invalid-contacts.patch media-cec-copy-sequence-field-for-the-reply.patch revert-parisc-fix-backtrace-to-always-include-init-funtion-names.patch staging-fbtft-fix-backlight.patch staging-rtl8192e-fix-use-after-free-in-_rtl92e_pci_disconnect.patch --- diff --git a/queue-5.4/alsa-ctxfi-fix-out-of-range-access.patch b/queue-5.4/alsa-ctxfi-fix-out-of-range-access.patch new file mode 100644 index 00000000000..ef8b2b14e9f --- /dev/null +++ b/queue-5.4/alsa-ctxfi-fix-out-of-range-access.patch @@ -0,0 +1,181 @@ +From 76c47183224c86e4011048b80f0e2d0d166f01c2 Mon Sep 17 00:00:00 2001 +From: Takashi Iwai +Date: Thu, 18 Nov 2021 22:57:29 +0100 +Subject: ALSA: ctxfi: Fix out-of-range access + +From: Takashi Iwai + +commit 76c47183224c86e4011048b80f0e2d0d166f01c2 upstream. + +The master and next_conj of rcs_ops are used for iterating the +resource list entries, and currently those are supposed to return the +current value. The problem is that next_conf may go over the last +entry before the loop abort condition is evaluated, and it may return +the "current" value that is beyond the array size. It was caught +recently as a GPF, for example. + +Those return values are, however, never actually evaluated, hence +basically we don't have to consider the current value as the return at +all. By dropping those return values, the potential out-of-range +access above is also fixed automatically. + +This patch changes the return type of master and next_conj callbacks +to void and drop the superfluous code accordingly. + +BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214985 +Cc: +Link: https://lore.kernel.org/r/20211118215729.26257-1-tiwai@suse.de +Signed-off-by: Takashi Iwai +Signed-off-by: Greg Kroah-Hartman +--- + sound/pci/ctxfi/ctamixer.c | 14 ++++++-------- + sound/pci/ctxfi/ctdaio.c | 16 ++++++++-------- + sound/pci/ctxfi/ctresource.c | 7 +++---- + sound/pci/ctxfi/ctresource.h | 4 ++-- + sound/pci/ctxfi/ctsrc.c | 7 +++---- + 5 files changed, 22 insertions(+), 26 deletions(-) + +--- a/sound/pci/ctxfi/ctamixer.c ++++ b/sound/pci/ctxfi/ctamixer.c +@@ -23,16 +23,15 @@ + + #define BLANK_SLOT 4094 + +-static int amixer_master(struct rsc *rsc) ++static void amixer_master(struct rsc *rsc) + { + rsc->conj = 0; +- return rsc->idx = container_of(rsc, struct amixer, rsc)->idx[0]; ++ rsc->idx = container_of(rsc, struct amixer, rsc)->idx[0]; + } + +-static int amixer_next_conj(struct rsc *rsc) ++static void amixer_next_conj(struct rsc *rsc) + { + rsc->conj++; +- return container_of(rsc, struct amixer, rsc)->idx[rsc->conj]; + } + + static int amixer_index(const struct rsc *rsc) +@@ -331,16 +330,15 @@ int amixer_mgr_destroy(struct amixer_mgr + + /* SUM resource management */ + +-static int sum_master(struct rsc *rsc) ++static void sum_master(struct rsc *rsc) + { + rsc->conj = 0; +- return rsc->idx = container_of(rsc, struct sum, rsc)->idx[0]; ++ rsc->idx = container_of(rsc, struct sum, rsc)->idx[0]; + } + +-static int sum_next_conj(struct rsc *rsc) ++static void sum_next_conj(struct rsc *rsc) + { + rsc->conj++; +- return container_of(rsc, struct sum, rsc)->idx[rsc->conj]; + } + + static int sum_index(const struct rsc *rsc) +--- a/sound/pci/ctxfi/ctdaio.c ++++ b/sound/pci/ctxfi/ctdaio.c +@@ -51,12 +51,12 @@ static struct daio_rsc_idx idx_20k2[NUM_ + [SPDIFIO] = {.left = 0x05, .right = 0x85}, + }; + +-static int daio_master(struct rsc *rsc) ++static void daio_master(struct rsc *rsc) + { + /* Actually, this is not the resource index of DAIO. + * For DAO, it is the input mapper index. And, for DAI, + * it is the output time-slot index. */ +- return rsc->conj = rsc->idx; ++ rsc->conj = rsc->idx; + } + + static int daio_index(const struct rsc *rsc) +@@ -64,19 +64,19 @@ static int daio_index(const struct rsc * + return rsc->conj; + } + +-static int daio_out_next_conj(struct rsc *rsc) ++static void daio_out_next_conj(struct rsc *rsc) + { +- return rsc->conj += 2; ++ rsc->conj += 2; + } + +-static int daio_in_next_conj_20k1(struct rsc *rsc) ++static void daio_in_next_conj_20k1(struct rsc *rsc) + { +- return rsc->conj += 0x200; ++ rsc->conj += 0x200; + } + +-static int daio_in_next_conj_20k2(struct rsc *rsc) ++static void daio_in_next_conj_20k2(struct rsc *rsc) + { +- return rsc->conj += 0x100; ++ rsc->conj += 0x100; + } + + static const struct rsc_ops daio_out_rsc_ops = { +--- a/sound/pci/ctxfi/ctresource.c ++++ b/sound/pci/ctxfi/ctresource.c +@@ -109,18 +109,17 @@ static int audio_ring_slot(const struct + return (rsc->conj << 4) + offset_in_audio_slot_block[rsc->type]; + } + +-static int rsc_next_conj(struct rsc *rsc) ++static void rsc_next_conj(struct rsc *rsc) + { + unsigned int i; + for (i = 0; (i < 8) && (!(rsc->msr & (0x1 << i))); ) + i++; + rsc->conj += (AUDIO_SLOT_BLOCK_NUM >> i); +- return rsc->conj; + } + +-static int rsc_master(struct rsc *rsc) ++static void rsc_master(struct rsc *rsc) + { +- return rsc->conj = rsc->idx; ++ rsc->conj = rsc->idx; + } + + static const struct rsc_ops rsc_generic_ops = { +--- a/sound/pci/ctxfi/ctresource.h ++++ b/sound/pci/ctxfi/ctresource.h +@@ -39,8 +39,8 @@ struct rsc { + }; + + struct rsc_ops { +- int (*master)(struct rsc *rsc); /* Move to master resource */ +- int (*next_conj)(struct rsc *rsc); /* Move to next conjugate resource */ ++ void (*master)(struct rsc *rsc); /* Move to master resource */ ++ void (*next_conj)(struct rsc *rsc); /* Move to next conjugate resource */ + int (*index)(const struct rsc *rsc); /* Return the index of resource */ + /* Return the output slot number */ + int (*output_slot)(const struct rsc *rsc); +--- a/sound/pci/ctxfi/ctsrc.c ++++ b/sound/pci/ctxfi/ctsrc.c +@@ -590,16 +590,15 @@ int src_mgr_destroy(struct src_mgr *src_ + + /* SRCIMP resource manager operations */ + +-static int srcimp_master(struct rsc *rsc) ++static void srcimp_master(struct rsc *rsc) + { + rsc->conj = 0; +- return rsc->idx = container_of(rsc, struct srcimp, rsc)->idx[0]; ++ rsc->idx = container_of(rsc, struct srcimp, rsc)->idx[0]; + } + +-static int srcimp_next_conj(struct rsc *rsc) ++static void srcimp_next_conj(struct rsc *rsc) + { + rsc->conj++; +- return container_of(rsc, struct srcimp, rsc)->idx[rsc->conj]; + } + + static int srcimp_index(const struct rsc *rsc) diff --git a/queue-5.4/binder-fix-test-regression-due-to-sender_euid-change.patch b/queue-5.4/binder-fix-test-regression-due-to-sender_euid-change.patch new file mode 100644 index 00000000000..efb6e2fe80f --- /dev/null +++ b/queue-5.4/binder-fix-test-regression-due-to-sender_euid-change.patch @@ -0,0 +1,37 @@ +From c21a80ca0684ec2910344d72556c816cb8940c01 Mon Sep 17 00:00:00 2001 +From: Todd Kjos +Date: Fri, 12 Nov 2021 10:07:20 -0800 +Subject: binder: fix test regression due to sender_euid change + +From: Todd Kjos + +commit c21a80ca0684ec2910344d72556c816cb8940c01 upstream. + +This is a partial revert of commit +29bc22ac5e5b ("binder: use euid from cred instead of using task"). +Setting sender_euid using proc->cred caused some Android system test +regressions that need further investigation. It is a partial +reversion because subsequent patches rely on proc->cred. + +Fixes: 29bc22ac5e5b ("binder: use euid from cred instead of using task") +Cc: stable@vger.kernel.org # 4.4+ +Acked-by: Christian Brauner +Signed-off-by: Todd Kjos +Change-Id: I9b1769a3510fed250bb21859ef8beebabe034c66 +Link: https://lore.kernel.org/r/20211112180720.2858135-1-tkjos@google.com +Signed-off-by: Greg Kroah-Hartman +--- + drivers/android/binder.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/drivers/android/binder.c ++++ b/drivers/android/binder.c +@@ -3095,7 +3095,7 @@ static void binder_transaction(struct bi + t->from = thread; + else + t->from = NULL; +- t->sender_euid = proc->cred->euid; ++ t->sender_euid = task_euid(proc->tsk); + t->to_proc = target_proc; + t->to_thread = target_thread; + t->code = tr->code; diff --git a/queue-5.4/hid-wacom-use-confidence-flag-to-prevent-reporting-invalid-contacts.patch b/queue-5.4/hid-wacom-use-confidence-flag-to-prevent-reporting-invalid-contacts.patch new file mode 100644 index 00000000000..a0cd438047a --- /dev/null +++ b/queue-5.4/hid-wacom-use-confidence-flag-to-prevent-reporting-invalid-contacts.patch @@ -0,0 +1,81 @@ +From 7fb0413baa7f8a04caef0c504df9af7e0623d296 Mon Sep 17 00:00:00 2001 +From: Jason Gerecke +Date: Mon, 8 Nov 2021 16:31:01 -0800 +Subject: HID: wacom: Use "Confidence" flag to prevent reporting invalid contacts + +From: Jason Gerecke + +commit 7fb0413baa7f8a04caef0c504df9af7e0623d296 upstream. + +The HID descriptor of many of Wacom's touch input devices include a +"Confidence" usage that signals if a particular touch collection contains +useful data. The driver does not look at this flag, however, which causes +even invalid contacts to be reported to userspace. A lucky combination of +kernel event filtering and device behavior (specifically: contact ID 0 == +invalid, contact ID >0 == valid; and order all data so that all valid +contacts are reported before any invalid contacts) spare most devices from +any visibly-bad behavior. + +The DTH-2452 is one example of an unlucky device that misbehaves. It uses +ID 0 for both the first valid contact and all invalid contacts. Because +we report both the valid and invalid contacts, the kernel reports that +contact 0 first goes down (valid) and then goes up (invalid) in every +report. This causes ~100 clicks per second simply by touching the screen. + +This patch inroduces new `confidence` flag in our `hid_data` structure. +The value is initially set to `true` at the start of a report and can be +set to `false` if an invalid touch usage is seen. + +Link: https://github.com/linuxwacom/input-wacom/issues/270 +Fixes: f8b6a74719b5 ("HID: wacom: generic: Support multiple tools per report") +Signed-off-by: Jason Gerecke +Tested-by: Joshua Dickens +Cc: +Signed-off-by: Jiri Kosina +Signed-off-by: Greg Kroah-Hartman +--- + drivers/hid/wacom_wac.c | 8 +++++++- + drivers/hid/wacom_wac.h | 1 + + 2 files changed, 8 insertions(+), 1 deletion(-) + +--- a/drivers/hid/wacom_wac.c ++++ b/drivers/hid/wacom_wac.c +@@ -2578,6 +2578,9 @@ static void wacom_wac_finger_event(struc + return; + + switch (equivalent_usage) { ++ case HID_DG_CONFIDENCE: ++ wacom_wac->hid_data.confidence = value; ++ break; + case HID_GD_X: + wacom_wac->hid_data.x = value; + break; +@@ -2610,7 +2613,8 @@ static void wacom_wac_finger_event(struc + } + + if (usage->usage_index + 1 == field->report_count) { +- if (equivalent_usage == wacom_wac->hid_data.last_slot_field) ++ if (equivalent_usage == wacom_wac->hid_data.last_slot_field && ++ wacom_wac->hid_data.confidence) + wacom_wac_finger_slot(wacom_wac, wacom_wac->touch_input); + } + } +@@ -2625,6 +2629,8 @@ static void wacom_wac_finger_pre_report( + + wacom_wac->is_invalid_bt_frame = false; + ++ hid_data->confidence = true; ++ + for (i = 0; i < report->maxfield; i++) { + struct hid_field *field = report->field[i]; + int j; +--- a/drivers/hid/wacom_wac.h ++++ b/drivers/hid/wacom_wac.h +@@ -300,6 +300,7 @@ struct hid_data { + bool tipswitch; + bool barrelswitch; + bool barrelswitch2; ++ bool confidence; + int x; + int y; + int pressure; diff --git a/queue-5.4/media-cec-copy-sequence-field-for-the-reply.patch b/queue-5.4/media-cec-copy-sequence-field-for-the-reply.patch new file mode 100644 index 00000000000..168a2b8c906 --- /dev/null +++ b/queue-5.4/media-cec-copy-sequence-field-for-the-reply.patch @@ -0,0 +1,34 @@ +From 13cbaa4c2b7bf9f8285e1164d005dbf08244ecd5 Mon Sep 17 00:00:00 2001 +From: Hans Verkuil +Date: Tue, 2 Nov 2021 12:24:26 +0000 +Subject: media: cec: copy sequence field for the reply + +From: Hans Verkuil + +commit 13cbaa4c2b7bf9f8285e1164d005dbf08244ecd5 upstream. + +When the reply for a non-blocking transmit arrives, the sequence +field for that reply was never filled in, so userspace would have no +way of associating the reply to the original transmit. + +Copy the sequence field to ensure that this is now possible. + +Signed-off-by: Hans Verkuil +Fixes: 0dbacebede1e ([media] cec: move the CEC framework out of staging and to media) +Cc: +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Greg Kroah-Hartman +--- + drivers/media/cec/cec-adap.c | 1 + + 1 file changed, 1 insertion(+) + +--- a/drivers/media/cec/cec-adap.c ++++ b/drivers/media/cec/cec-adap.c +@@ -1191,6 +1191,7 @@ void cec_received_msg_ts(struct cec_adap + if (abort) + dst->rx_status |= CEC_RX_STATUS_FEATURE_ABORT; + msg->flags = dst->flags; ++ msg->sequence = dst->sequence; + /* Remove it from the wait_queue */ + list_del_init(&data->list); + diff --git a/queue-5.4/revert-parisc-fix-backtrace-to-always-include-init-funtion-names.patch b/queue-5.4/revert-parisc-fix-backtrace-to-always-include-init-funtion-names.patch new file mode 100644 index 00000000000..4261c5f1a1f --- /dev/null +++ b/queue-5.4/revert-parisc-fix-backtrace-to-always-include-init-funtion-names.patch @@ -0,0 +1,59 @@ +From 98400ad75e95860e9a10ec78b0b90ab66184a2ce Mon Sep 17 00:00:00 2001 +From: Helge Deller +Date: Sun, 21 Nov 2021 11:10:55 +0100 +Subject: Revert "parisc: Fix backtrace to always include init funtion names" + +From: Helge Deller + +commit 98400ad75e95860e9a10ec78b0b90ab66184a2ce upstream. + +This reverts commit 279917e27edc293eb645a25428c6ab3f3bca3f86. + +With the CONFIG_HARDENED_USERCOPY option enabled, this patch triggers +kernel bugs at runtime: + + usercopy: Kernel memory overwrite attempt detected to kernel text (offset 2084839, size 6)! + kernel BUG at mm/usercopy.c:99! + Backtrace: + IAOQ[0]: usercopy_abort+0xc4/0xe8 + [<00000000406ed1c8>] __check_object_size+0x174/0x238 + [<00000000407086d4>] copy_strings.isra.0+0x3e8/0x708 + [<0000000040709a20>] do_execveat_common.isra.0+0x1bc/0x328 + [<000000004070b760>] compat_sys_execve+0x7c/0xb8 + [<0000000040303eb8>] syscall_exit+0x0/0x14 + +The problem is, that we have an init section of at least 2MB size which +starts at _stext and is freed after bootup. + +If then later some kernel data is (temporarily) stored in this free +memory, check_kernel_text_object() will trigger a bug since the data +appears to be inside the kernel text (>=_stext) area: + if (overlaps(ptr, len, _stext, _etext)) + usercopy_abort("kernel text"); + +Signed-off-by: Helge Deller +Cc: stable@kernel.org # 5.4+ +Signed-off-by: Greg Kroah-Hartman +--- + arch/parisc/kernel/vmlinux.lds.S | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +--- a/arch/parisc/kernel/vmlinux.lds.S ++++ b/arch/parisc/kernel/vmlinux.lds.S +@@ -56,8 +56,6 @@ SECTIONS + { + . = KERNEL_BINARY_TEXT_START; + +- _stext = .; /* start of kernel text, includes init code & data */ +- + __init_begin = .; + HEAD_TEXT_SECTION + MLONGCALL_DISCARD(INIT_TEXT_SECTION(8)) +@@ -81,6 +79,7 @@ SECTIONS + /* freed after init ends here */ + + _text = .; /* Text and read-only data */ ++ _stext = .; + MLONGCALL_KEEP(INIT_TEXT_SECTION(8)) + .text ALIGN(PAGE_SIZE) : { + TEXT_TEXT diff --git a/queue-5.4/series b/queue-5.4/series index 2ca644227c0..35c88ee54cc 100644 --- a/queue-5.4/series +++ b/queue-5.4/series @@ -6,3 +6,10 @@ net-nexthop-fix-null-pointer-dereference-when-ipv6-is-not-enabled.patch usb-typec-fusb302-fix-masking-of-comparator-and-bc_lvl-interrupts.patch usb-hub-fix-usb-enumeration-issue-due-to-address0-race.patch usb-hub-fix-locking-issues-with-address0_mutex.patch +binder-fix-test-regression-due-to-sender_euid-change.patch +alsa-ctxfi-fix-out-of-range-access.patch +media-cec-copy-sequence-field-for-the-reply.patch +revert-parisc-fix-backtrace-to-always-include-init-funtion-names.patch +hid-wacom-use-confidence-flag-to-prevent-reporting-invalid-contacts.patch +staging-fbtft-fix-backlight.patch +staging-rtl8192e-fix-use-after-free-in-_rtl92e_pci_disconnect.patch diff --git a/queue-5.4/staging-fbtft-fix-backlight.patch b/queue-5.4/staging-fbtft-fix-backlight.patch new file mode 100644 index 00000000000..ddb97b5acca --- /dev/null +++ b/queue-5.4/staging-fbtft-fix-backlight.patch @@ -0,0 +1,94 @@ +From 7865dd24934ad580d1bcde8f63c39f324211a23b Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= +Date: Fri, 5 Nov 2021 21:43:58 +0100 +Subject: staging/fbtft: Fix backlight +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Noralf Trønnes + +commit 7865dd24934ad580d1bcde8f63c39f324211a23b upstream. + +Commit b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") forgot to +update fbtft breaking its backlight support when FB_BACKLIGHT is a module. + +Since FB_TFT selects FB_BACKLIGHT there's no need for this conditional +so just remove it and we're good. + +Fixes: b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") +Cc: +Acked-by: Sam Ravnborg +Signed-off-by: Noralf Trønnes +Link: https://lore.kernel.org/r/20211105204358.2991-1-noralf@tronnes.org +Signed-off-by: Greg Kroah-Hartman +--- + drivers/staging/fbtft/fb_ssd1351.c | 4 ---- + drivers/staging/fbtft/fbtft-core.c | 9 +-------- + 2 files changed, 1 insertion(+), 12 deletions(-) + +--- a/drivers/staging/fbtft/fb_ssd1351.c ++++ b/drivers/staging/fbtft/fb_ssd1351.c +@@ -187,7 +187,6 @@ static struct fbtft_display display = { + }, + }; + +-#ifdef CONFIG_FB_BACKLIGHT + static int update_onboard_backlight(struct backlight_device *bd) + { + struct fbtft_par *par = bl_get_data(bd); +@@ -231,9 +230,6 @@ static void register_onboard_backlight(s + if (!par->fbtftops.unregister_backlight) + par->fbtftops.unregister_backlight = fbtft_unregister_backlight; + } +-#else +-static void register_onboard_backlight(struct fbtft_par *par) { }; +-#endif + + FBTFT_REGISTER_DRIVER(DRVNAME, "solomon,ssd1351", &display); + +--- a/drivers/staging/fbtft/fbtft-core.c ++++ b/drivers/staging/fbtft/fbtft-core.c +@@ -136,7 +136,6 @@ static int fbtft_request_gpios_dt(struct + } + #endif + +-#ifdef CONFIG_FB_BACKLIGHT + static int fbtft_backlight_update_status(struct backlight_device *bd) + { + struct fbtft_par *par = bl_get_data(bd); +@@ -169,6 +168,7 @@ void fbtft_unregister_backlight(struct f + par->info->bl_dev = NULL; + } + } ++EXPORT_SYMBOL(fbtft_unregister_backlight); + + static const struct backlight_ops fbtft_bl_ops = { + .get_brightness = fbtft_backlight_get_brightness, +@@ -206,12 +206,7 @@ void fbtft_register_backlight(struct fbt + if (!par->fbtftops.unregister_backlight) + par->fbtftops.unregister_backlight = fbtft_unregister_backlight; + } +-#else +-void fbtft_register_backlight(struct fbtft_par *par) { }; +-void fbtft_unregister_backlight(struct fbtft_par *par) { }; +-#endif + EXPORT_SYMBOL(fbtft_register_backlight); +-EXPORT_SYMBOL(fbtft_unregister_backlight); + + static void fbtft_set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, + int ye) +@@ -860,13 +855,11 @@ int fbtft_register_framebuffer(struct fb + fb_info->fix.smem_len >> 10, text1, + HZ / fb_info->fbdefio->delay, text2); + +-#ifdef CONFIG_FB_BACKLIGHT + /* Turn on backlight if available */ + if (fb_info->bl_dev) { + fb_info->bl_dev->props.power = FB_BLANK_UNBLANK; + fb_info->bl_dev->ops->update_status(fb_info->bl_dev); + } +-#endif + + return 0; + diff --git a/queue-5.4/staging-rtl8192e-fix-use-after-free-in-_rtl92e_pci_disconnect.patch b/queue-5.4/staging-rtl8192e-fix-use-after-free-in-_rtl92e_pci_disconnect.patch new file mode 100644 index 00000000000..db4dc5e5c5b --- /dev/null +++ b/queue-5.4/staging-rtl8192e-fix-use-after-free-in-_rtl92e_pci_disconnect.patch @@ -0,0 +1,39 @@ +From b535917c51acc97fb0761b1edec85f1f3d02bda4 Mon Sep 17 00:00:00 2001 +From: Dan Carpenter +Date: Wed, 17 Nov 2021 10:20:16 +0300 +Subject: staging: rtl8192e: Fix use after free in _rtl92e_pci_disconnect() + +From: Dan Carpenter + +commit b535917c51acc97fb0761b1edec85f1f3d02bda4 upstream. + +The free_rtllib() function frees the "dev" pointer so there is use +after free on the next line. Re-arrange things to avoid that. + +Fixes: 66898177e7e5 ("staging: rtl8192e: Fix unload/reload problem") +Cc: stable +Signed-off-by: Dan Carpenter +Link: https://lore.kernel.org/r/20211117072016.GA5237@kili +Signed-off-by: Greg Kroah-Hartman +--- + drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c ++++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +@@ -2559,13 +2559,14 @@ static void _rtl92e_pci_disconnect(struc + free_irq(dev->irq, dev); + priv->irq = 0; + } +- free_rtllib(dev); + + if (dev->mem_start != 0) { + iounmap((void __iomem *)dev->mem_start); + release_mem_region(pci_resource_start(pdev, 1), + pci_resource_len(pdev, 1)); + } ++ ++ free_rtllib(dev); + } else { + priv = rtllib_priv(dev); + }