From: Juan Quintela <quintela@redhat.com>
Date: Thu, 4 Mar 2010 09:00:36 +0000 (+0100)
Subject: vmdk: fix double free
X-Git-Tag: v0.13.0-rc0~1141
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a161329b61106ab093aab6d3227ac85e0b8251a9;p=thirdparty%2Fqemu.git

vmdk: fix double free

fail_gd error case would also free rgd_buf that was already freed

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/block/vmdk.c b/block/vmdk.c
index 67a690e255d..819c1c9fc5b 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -315,7 +315,6 @@ static int vmdk_snapshot_create(const char *filename, const char *backing_file)
         ret = -errno;
         goto fail_rgd;
     }
-    qemu_free(rgd_buf);
 
     /* write GD */
     gd_buf = qemu_malloc(gd_size);
@@ -336,6 +335,7 @@ static int vmdk_snapshot_create(const char *filename, const char *backing_file)
         goto fail_gd;
     }
     qemu_free(gd_buf);
+    qemu_free(rgd_buf);
 
     close(p_fd);
     close(snp_fd);