From: Taylor Blau <me@ttaylorr.com>
Date: Wed, 28 May 2025 18:47:12 +0000 (-0400)
Subject: Sync with 2.43.7
X-Git-Tag: v2.44.4~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a162459bf6f4ec84297b67428597afb9ae2db706;p=thirdparty%2Fgit.git

Sync with 2.43.7

* maint-2.43:
  Git 2.43.7
  wincred: avoid buffer overflow in wcsncat()
  bundle-uri: fix arbitrary file writes via parameter injection
  config: quote values containing CR character
  git-gui: sanitize 'exec' arguments: convert new 'cygpath' calls
  git-gui: do not mistake command arguments as redirection operators
  git-gui: introduce function git_redir for git calls with redirections
  git-gui: pass redirections as separate argument to git_read
  git-gui: pass redirections as separate argument to _open_stdout_stderr
  git-gui: convert git_read*, git_write to be non-variadic
  git-gui: override exec and open only on Windows
  gitk: sanitize 'open' arguments: revisit recently updated 'open' calls
  git-gui: use git_read in githook_read
  git-gui: sanitize $PATH on all platforms
  git-gui: break out a separate function git_read_nice
  git-gui: assure PATH has only absolute elements.
  git-gui: remove option --stderr from git_read
  git-gui: cleanup git-bash menu item
  git-gui: sanitize 'exec' arguments: background
  git-gui: avoid auto_execok in do_windows_shortcut
  git-gui: sanitize 'exec' arguments: simple cases
  git-gui: avoid auto_execok for git-bash menu item
  git-gui: treat file names beginning with "|" as relative paths
  git-gui: remove unused proc is_shellscript
  git-gui: remove git config --list handling for git < 1.5.3
  git-gui: remove special treatment of Windows from open_cmd_pipe
  git-gui: remove HEAD detachment implementation for git < 1.5.3
  git-gui: use only the configured shell
  git-gui: remove Tcl 8.4 workaround on 2>@1 redirection
  git-gui: make _shellpath usable on startup
  git-gui: use [is_Windows], not bad _shellpath
  git-gui: _which, only add .exe suffix if not present
  gitk: encode arguments correctly with "open"
  gitk: sanitize 'open' arguments: command pipeline
  gitk: collect construction of blameargs into a single conditional
  gitk: sanitize 'open' arguments: simple commands, readable and writable
  gitk: sanitize 'open' arguments: simple commands with redirections
  gitk: sanitize 'open' arguments: simple commands
  gitk: sanitize 'exec' arguments: redirect to process
  gitk: sanitize 'exec' arguments: redirections and background
  gitk: sanitize 'exec' arguments: redirections
  gitk: sanitize 'exec' arguments: 'eval exec'
  gitk: sanitize 'exec' arguments: simple cases
  gitk: have callers of diffcmd supply pipe symbol when necessary
  gitk: treat file names beginning with "|" as relative paths

Signed-off-by: Taylor Blau <me@ttaylorr.com>
---

a162459bf6f4ec84297b67428597afb9ae2db706
diff --cc contrib/credential/wincred/git-credential-wincred.c
index 4be0d58cd8,ceff44207a..3c16b74f52
--- a/contrib/credential/wincred/git-credential-wincred.c
+++ b/contrib/credential/wincred/git-credential-wincred.c
@@@ -35,8 -35,16 +35,16 @@@ static void *xmalloc(size_t size
  }
  
  static WCHAR *wusername, *password, *protocol, *host, *path, target[1024],
 -	*password_expiry_utc;
 +	*password_expiry_utc, *oauth_refresh_token;
  
+ static void target_append(const WCHAR *src)
+ {
+ 	size_t avail = ARRAY_SIZE(target) - wcslen(target) - 1; /* -1 for NUL */
+ 	if (avail < wcslen(src))
+ 		die("target buffer overflow");
+ 	wcsncat(target, src, avail);
+ }
+ 
  static void write_item(const char *what, LPCWSTR wbuf, int wlen)
  {
  	char *buf;