From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Thu, 23 Jun 2011 21:03:57 +0000 (-0600)
Subject: Removed pointless call to maybeReadVirginBody() for aborted entries.
X-Git-Tag: take08~55^2~99
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a171b5f02981cbd19fde655a2ed8620f70de0fff;p=thirdparty%2Fsquid.git

Removed pointless call to maybeReadVirginBody() for aborted entries.
No runtime changes expected.

Setting flags.do_next_read to zero and then calling maybeReadVirginBody() is
pointless because maybeReadVirginBody() does nothing but wasting cycles when
the flag is zero. Also, even if we do manage to read the virgin response body
somehow, we cannot write it to the aborted store entry anyway.
---

diff --git a/src/http.cc b/src/http.cc
index 114b9b7190..d1bfcc0438 100644
--- a/src/http.cc
+++ b/src/http.cc
@@ -1095,7 +1095,7 @@ HttpStateData::readReply(const CommIoCbParams &io)
     }
 
     if (EBIT_TEST(entry->flags, ENTRY_ABORTED)) {
-        maybeReadVirginBody();
+        // TODO: should we call abortTransaction() here?
         return;
     }