From: Manuel Fombuena Date: Wed, 26 Feb 2025 17:06:40 +0000 (+0000) Subject: leds: leds-st1202: Initialize hardware before DT node child operations X-Git-Tag: v6.15-rc1~108^2~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a17d9e736ddd78323e77d3066c1e86371a99023c;p=thirdparty%2Flinux.git leds: leds-st1202: Initialize hardware before DT node child operations Arguably, there are more chances of errors occurring during the initialization of the hardware, so this should complete successfully before the devicetree node's children are initialized. st1202_dt_init() fills the led_classdev struct. st1202_setup() initializes the hardware. Specifically, resets the chip, enables its phase-shift delay feature, enables the device and disables all the LEDs channels. All that writing to registers, with no input from st1202_dt_init(). Real-world testing corroborates that calling st1202_setup() before st1202_dt_init() doesn't cause any issue during initialization. Switch the order of st1202_dt_init() and st1202_setup() to ensure the hardware is correctly initialized before the led_classdev struct is filled. Signed-off-by: Manuel Fombuena Link: https://lore.kernel.org/r/CWLP123MB54731877A8DC54EDD33F0229C5C22@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM Signed-off-by: Lee Jones --- diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index 360e9db78dc10..3ddf2786a7452 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -360,11 +360,11 @@ static int st1202_probe(struct i2c_client *client) return ret; chip->client = client; - ret = st1202_dt_init(chip); + ret = st1202_setup(chip); if (ret < 0) return ret; - ret = st1202_setup(chip); + ret = st1202_dt_init(chip); if (ret < 0) return ret;