From: Pauli <pauli@openssl.org>
Date: Mon, 8 Nov 2021 01:27:59 +0000 (+1000)
Subject: x509: remove dead call to strlen()
X-Git-Tag: openssl-3.2.0-alpha1~3372
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a18cdd28077be05ec88538be84a761469f3f20c4;p=thirdparty%2Fopenssl.git

x509: remove dead call to strlen()

The condition `userlen == -1` isn't possible because this is already checked
on line 159 above and the subsequent strlen(3) call guarantees that it's value
is positive.

Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
(Merged from https://github.com/openssl/openssl/pull/16987)
---

diff --git a/crypto/x509/v3_sxnet.c b/crypto/x509/v3_sxnet.c
index 3e5ae048be5..4b19ce07d53 100644
--- a/crypto/x509/v3_sxnet.c
+++ b/crypto/x509/v3_sxnet.c
@@ -177,8 +177,6 @@ int SXNET_add_id_INTEGER(SXNET **psx, ASN1_INTEGER *zone, const char *user,
 
     if ((id = SXNETID_new()) == NULL)
         goto err;
-    if (userlen == -1)
-        userlen = strlen(user);
 
     if (!ASN1_OCTET_STRING_set(id->user, (const unsigned char *)user, userlen))
         goto err;