From: Josef 'Jeff' Sipek <jeff.sipek@open-xchange.com>
Date: Thu, 12 Nov 2020 18:49:49 +0000 (-0500)
Subject: lib: event-filter - Do not assert that there in no output on error
X-Git-Tag: 2.3.14.rc1~339
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a19514bbd38d978213e0e4742b5400d194bcaec8;p=thirdparty%2Fdovecot%2Fcore.git

lib: event-filter - Do not assert that there in no output on error

When the input is a simple (but invalid) expression (e.g., a=b=c) the output
variable may be set.  This is perfectly fine.

The assertion (and the associated failure) come from when event filter
parsing was switched to the new filter syntax
(fcba1d530737813de11d9d730d5db6496e2e574b).
---

diff --git a/src/lib/event-filter.c b/src/lib/event-filter.c
index 46882e0811..40a1406be7 100644
--- a/src/lib/event-filter.c
+++ b/src/lib/event-filter.c
@@ -134,7 +134,6 @@ int event_filter_parse(const char *str, struct event_filter *filter,
 		filter->named_queries_only = filter->named_queries_only && state.has_event_name;
 	} else if (ret != 0) {
 		/* error */
-		i_assert(state.output == NULL);
 		i_assert(state.error != NULL);
 
 		*error_r = state.error;