From: dklawren <dklawren@users.noreply.github.com>
Date: Wed, 12 Jun 2019 19:36:58 +0000 (-0400)
Subject: Bug 1557726 - Remove author column from Phabricator table to avoid revision owner... 
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a1d2130c4aa610561c551d33f0a3989dff4285ce;p=thirdparty%2Fbugzilla.git

Bug 1557726 - Remove author column from Phabricator table to avoid revision owner vs. commit author confusion
---

diff --git a/extensions/PhabBugz/lib/WebService.pm b/extensions/PhabBugz/lib/WebService.pm
index 4e555b977..8376e6ad4 100644
--- a/extensions/PhabBugz/lib/WebService.pm
+++ b/extensions/PhabBugz/lib/WebService.pm
@@ -173,7 +173,6 @@ sub bug_revisions {
     my $revision_data = {
       id          => 'D' . $revision_obj->id,
       sortkey     => $revision_obj->id,
-      author      => $revision_obj->author->name,
       status      => $revision_obj->status,
       long_status => $revision_status_map->{$revision_obj->status}
         || $revision_obj->status
diff --git a/extensions/PhabBugz/template/en/default/phabricator/table.html.tmpl b/extensions/PhabBugz/template/en/default/phabricator/table.html.tmpl
index c55a039f1..adf429e81 100644
--- a/extensions/PhabBugz/template/en/default/phabricator/table.html.tmpl
+++ b/extensions/PhabBugz/template/en/default/phabricator/table.html.tmpl
@@ -12,7 +12,6 @@
     <tr>
       <th>ID</th>
       <th>Title</th>
-      <th>Author</th>
       <th>Status</th>
       <th>Reviewers</th>
     </tr>
diff --git a/extensions/PhabBugz/web/js/phabricator.js b/extensions/PhabBugz/web/js/phabricator.js
index 5604f2e5b..10a390ab0 100644
--- a/extensions/PhabBugz/web/js/phabricator.js
+++ b/extensions/PhabBugz/web/js/phabricator.js
@@ -20,7 +20,6 @@ Phabricator.getBugRevisions = function() {
         var trRevision     = tr.clone();
         var tdId           = td.clone();
         var tdTitle        = td.clone();
-        var tdAuthor       = td.clone();
         var tdRevisionStatus       = td.clone();
         var tdReviewers    = td.clone();
         var tableReviews   = table.clone();
@@ -37,8 +36,6 @@ Phabricator.getBugRevisions = function() {
         tdTitle.text(revision.title);
         tdTitle.addClass('phabricator-title');
 
-        tdAuthor.text(revision.author);
-
         spanRevisionStatusIcon.addClass('revision-status-icon-' + revision.status);
         spanRevisionStatus.append(spanRevisionStatusIcon);
         spanRevisionStatusText.text(revision.long_status);
@@ -72,7 +69,6 @@ Phabricator.getBugRevisions = function() {
         trRevision.append(
             tdId,
             tdTitle,
-            tdAuthor,
             tdRevisionStatus,
             tdReviewers
         );