From: Johannes Berg Date: Wed, 1 Mar 2023 10:09:24 +0000 (+0200) Subject: wifi: mac80211: warn only once on AP probe X-Git-Tag: v6.4-rc1~132^2~336^2~36 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a1e91ef92392e5da15a1a16f8545ede2c02f7049;p=thirdparty%2Fkernel%2Flinux.git wifi: mac80211: warn only once on AP probe We should perhaps support this API for MLO, but it's not clear that it makes sense, in any case then we'd have to update it to probe the correct BSS. For now, if it happens, warn only once so that we don't get flooded with messages if the driver misbehaves and calls this. Signed-off-by: Johannes Berg Signed-off-by: Gregory Greenman Link: https://lore.kernel.org/r/20230301115906.1c8499b6fbe6.I1a76a2be3b42ff93904870ac069f0319507adc23@changeid Signed-off-by: Johannes Berg --- diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 60792dfabc9d6..cdf842c0849b1 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -3227,7 +3227,7 @@ static void ieee80211_mgd_probe_ap(struct ieee80211_sub_if_data *sdata, struct ieee80211_if_managed *ifmgd = &sdata->u.mgd; bool already = false; - if (WARN_ON(sdata->vif.valid_links)) + if (WARN_ON_ONCE(sdata->vif.valid_links)) return; if (!ieee80211_sdata_running(sdata))