From: Adolf Belka Date: Thu, 19 Jun 2025 16:04:18 +0000 (+0200) Subject: setup: v2 Fixes bug10245 - removal of so called non-local network stop X-Git-Tag: v2.29-core196~7^2~24 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a21bc6e7ee0aab5b134e5058855eb634e9c892f1;p=ipfire-2.x.git setup: v2 Fixes bug10245 - removal of so called non-local network stop - In the setup menu if the OK button is pressed when it asks if you want to change any of the interfaces then the red, blue and orange interfaces are stopped. However if none of the interfaces are changed then the network restart code does not get used. - This results in the system ending up with only the green interfrace being UP and connected. - This patch removes the command that stops the red, blue & orange interfaces but leaves the green one running. It seems to not bhe needed and if the OK button is pressed on the Drivers and card assignments window but no change made then the IPFire system is left with only the green interface connected. - This command has been present since at least Core Update 30 and the bug was originally raised in 2012. - I tested out this v2 code on my vm testbed and everything worked fine and if any change was made then when leaving the Networking section the Network and Unbound were restarted. Fixes: bug10245 Tested-by: Adolf Belka Signed-off-by: Adolf Belka Signed-off-by: Michael Tremer --- diff --git a/src/setup/networking.c b/src/setup/networking.c index 8d398f365..98018b7f6 100644 --- a/src/setup/networking.c +++ b/src/setup/networking.c @@ -420,9 +420,6 @@ int changedrivers(void) errorbox(_("Unable to open settings file")); return 0; } - if (automode == 0) - runcommandwithstatus("/etc/rc.d/init.d/network stop red blue orange", - _("Networking"), _("Restarting non-local network..."), NULL); findkey(kv, "CONFIG_TYPE", temp); configtype = atol(temp); if (configtype == 1)