From: Guinevere Larsen <guinevere@redhat.com>
Date: Mon, 14 Oct 2024 11:58:29 +0000 (-0300)
Subject: gdb: make frame_unwind_try_unwinder return bool
X-Git-Tag: gdb-16-branchpoint~670
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a227513b8b7bcfcb7ee33a5c437cd9cf8e2bdc86;p=thirdparty%2Fbinutils-gdb.git

gdb: make frame_unwind_try_unwinder return bool

Before this commit, the function frame_unwind_try_unwinder would return
an int, where 1 meant the unwinder works, and 0 it doesn't. This is just
a boolean with extra steps, so this commit updates the function to
return bool instead.
---

diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c
index e5f108d3257..fecd1070e91 100644
--- a/gdb/frame-unwind.c
+++ b/gdb/frame-unwind.c
@@ -119,10 +119,10 @@ frame_unwind_append_unwinder (struct gdbarch *gdbarch,
 }
 
 /* Call SNIFFER from UNWINDER.  If it succeeded set UNWINDER for
-   THIS_FRAME and return 1.  Otherwise the function keeps THIS_FRAME
-   unchanged and returns 0.  */
+   THIS_FRAME and return true.  Otherwise the function keeps THIS_FRAME
+   unchanged and returns false.  */
 
-static int
+static bool
 frame_unwind_try_unwinder (const frame_info_ptr &this_frame, void **this_cache,
 			  const struct frame_unwind *unwinder)
 {
@@ -157,7 +157,7 @@ frame_unwind_try_unwinder (const frame_info_ptr &this_frame, void **this_cache,
 	     thus most unwinders aren't able to determine if they're
 	     the best fit.  Keep trying.  Fallback prologue unwinders
 	     should always accept the frame.  */
-	  return 0;
+	  return false;
 	}
       throw;
     }
@@ -165,7 +165,7 @@ frame_unwind_try_unwinder (const frame_info_ptr &this_frame, void **this_cache,
   if (res)
     {
       frame_debug_printf ("yes");
-      return 1;
+      return true;
     }
   else
     {
@@ -173,7 +173,7 @@ frame_unwind_try_unwinder (const frame_info_ptr &this_frame, void **this_cache,
       /* Don't set *THIS_CACHE to NULL here, because sniffer has to do
 	 so.  */
       frame_cleanup_after_sniffer (this_frame);
-      return 0;
+      return false;
     }
   gdb_assert_not_reached ("frame_unwind_try_unwinder");
 }