From: Tom de Vries Date: Wed, 12 Oct 2022 14:50:16 +0000 (+0200) Subject: [gdb/testsuite] Fix gdb.base/infoline-reloc-main-from-zero.exp with recent ld X-Git-Tag: gdb-13-branchpoint~902 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a2470500432334fe254ef10ddabcab239e8de828;p=thirdparty%2Fbinutils-gdb.git [gdb/testsuite] Fix gdb.base/infoline-reloc-main-from-zero.exp with recent ld On openSUSE Tumbleweed (with ld 2.39) and test-case gdb.base/infoline-reloc-main-from-zero.exp, I get: ... gdb compile failed, ld: warning: infoline-reloc-main-from-zero has a LOAD \ segment with RWX permissions UNTESTED: gdb.base/infoline-reloc-main-from-zero.exp: \ infoline-reloc-main-from-zero.exp ... Fix this by compiling with -Wl,--no-warn-rwx-segments. Tested on x86_64-linux. --- diff --git a/gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp b/gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp index 31e753a0c1c..35c2db00c07 100644 --- a/gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp +++ b/gdb/testsuite/gdb.base/infoline-reloc-main-from-zero.exp @@ -25,7 +25,15 @@ standard_testfile .c # Build executable with stripped startup code and text section starting at zero -set opts {debug "additional_flags=-nostdlib -emain -Wl,-Ttext=0x00 -Wl,-N"} +set opts {} +lappend opts debug +lappend opts "additional_flags=-nostdlib -emain -Wl,-Ttext=0x00 -Wl,-N" + +set ld_flags additional_flags=-Wl,--no-warn-rwx-segments +if { [gdb_can_simple_compile ld-flags {int main () { return 0; }} executable \ + $ld_flags] } { + lappend opts $ld_flags +} if {[build_executable $testfile.exp $testfile $srcfile $opts] == -1} { untested "failed to compile"