From: Jeff Layton Date: Mon, 23 Jul 2012 19:51:55 +0000 (-0400) Subject: sunrpc: clarify comments on rpc_make_runnable X-Git-Tag: v3.2.46~41 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a27e05b0cf32d711c1ec57625b6053658efd11fc;p=people%2Fms%2Flinux.git sunrpc: clarify comments on rpc_make_runnable commit 506026c3ec270e18402f0c9d33fee37482c23861 upstream. rpc_make_runnable is not generally called with the queue lock held, unless it's waking up a task that has been sitting on a waitqueue. This is safe when the task has not entered the FSM yet, but the comments don't really spell this out. Signed-off-by: Jeff Layton Signed-off-by: Trond Myklebust Signed-off-by: Ben Hutchings --- diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index dc6af2748e25..150848bf717c 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c @@ -296,8 +296,9 @@ EXPORT_SYMBOL_GPL(__rpc_wait_for_completion_task); /* * Make an RPC task runnable. * - * Note: If the task is ASYNC, this must be called with - * the spinlock held to protect the wait queue operation. + * Note: If the task is ASYNC, and is being made runnable after sitting on an + * rpc_wait_queue, this must be called with the queue spinlock held to protect + * the wait queue operation. */ static void rpc_make_runnable(struct rpc_task *task) {