From: Frederic Lecaille <flecaille@haproxy.com>
Date: Tue, 13 May 2025 14:15:51 +0000 (+0200)
Subject: CLEANUP: quic: Useless BIO_METHOD initialization
X-Git-Tag: v3.2-dev17~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a2822b17769408ce8fd17a4db4d58e5a4c0a1454;p=thirdparty%2Fhaproxy.git

CLEANUP: quic: Useless BIO_METHOD initialization

This code is there from QUIC implementation start. It was supposed to
initialize <ha_quic_meth> as a BIO_METHOD static object. But this
BIO_METHOD is not used at all!

Should be backported as far as 2.6 to help integrate the next patches to come.
---

diff --git a/src/quic_ssl.c b/src/quic_ssl.c
index 703dee1d8..7e409e31b 100644
--- a/src/quic_ssl.c
+++ b/src/quic_ssl.c
@@ -10,8 +10,6 @@
 #include <haproxy/ssl_sock.h>
 #include <haproxy/trace.h>
 
-static BIO_METHOD *ha_quic_meth;
-
 DECLARE_POOL(pool_head_quic_ssl_sock_ctx, "quic_ssl_sock_ctx", sizeof(struct ssl_sock_ctx));
 
 /* Set the encoded version of the transport parameter into the TLS
@@ -875,15 +873,3 @@ int qc_alloc_ssl_sock_ctx(struct quic_conn *qc)
 	pool_free(pool_head_quic_ssl_sock_ctx, ctx);
 	goto leave;
 }
-
-static void __quic_conn_init(void)
-{
-	ha_quic_meth = BIO_meth_new(0x666, "ha QUIC methods");
-}
-INITCALL0(STG_REGISTER, __quic_conn_init);
-
-static void __quic_conn_deinit(void)
-{
-	BIO_meth_free(ha_quic_meth);
-}
-REGISTER_POST_DEINIT(__quic_conn_deinit);