From: Alejandro Colomar <alx@kernel.org>
Date: Thu, 14 Nov 2024 17:45:07 +0000 (+0100)
Subject: lib/addgrps.c: add_groups(): Simplify redundant code with a goto
X-Git-Tag: 4.17.3~44
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a2841ce77c9a5688c9c3eba06bf9f19d65df6959;p=thirdparty%2Fshadow.git

lib/addgrps.c: add_groups(): Simplify redundant code with a goto

Reviewed-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/addgrps.c b/lib/addgrps.c
index b64fa4978..e65b06d27 100644
--- a/lib/addgrps.c
+++ b/lib/addgrps.c
@@ -88,11 +88,8 @@ add_groups(const char *list)
 	}
 
 	if (added) {
-		int  ret;
-
-		ret = setgroups (ngroups, grouplist);
-		free (grouplist);
-		return ret;
+		if (setgroups(ngroups, grouplist) == -1)
+			goto free_gids;
 	}
 
 	free (grouplist);