From: Uwe Kleine-König Date: Tue, 9 Jan 2024 21:34:31 +0000 (+0100) Subject: pwm: Fix out-of-bounds access in of_pwm_single_xlate() X-Git-Tag: v6.8-rc1~40^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a297d07b9a1e4fb8cda25a4a2363a507d294b7c9;p=thirdparty%2Fkernel%2Flinux.git pwm: Fix out-of-bounds access in of_pwm_single_xlate() With args->args_count == 2 args->args[2] is not defined. Actually the flags are contained in args->args[1]. Fixes: 3ab7b6ac5d82 ("pwm: Introduce single-PWM of_xlate function") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/243908750d306e018a3d4bf2eb745d53ab50f663.1704835845.git.u.kleine-koenig@pengutronix.de Signed-off-by: Uwe Kleine-König --- diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 9a4c720c88aad..f2728ee787d7a 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -152,7 +152,7 @@ of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) pwm->args.period = args->args[0]; pwm->args.polarity = PWM_POLARITY_NORMAL; - if (args->args_count == 2 && args->args[2] & PWM_POLARITY_INVERTED) + if (args->args_count == 2 && args->args[1] & PWM_POLARITY_INVERTED) pwm->args.polarity = PWM_POLARITY_INVERSED; return pwm;