From: Thomas Schwinge Date: Wed, 11 Aug 2021 09:59:19 +0000 (+0200) Subject: Address '?:' issues in 'libgomp.oacc-c-c++-common/mode-transitions.c' X-Git-Tag: basepoints/gcc-13~5387 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a2ab2f0dfba0fa69ebf6c82e34750911b2e5a639;p=thirdparty%2Fgcc.git Address '?:' issues in 'libgomp.oacc-c-c++-common/mode-transitions.c' [...]/libgomp.oacc-c-c++-common/mode-transitions.c: In function ‘t3’: [...]/libgomp.oacc-c-c++-common/mode-transitions.c:127:43: warning: ‘?:’ using integer constants in boolean context, the expression will always evaluate to ‘true’ [-Wint-in-bool-context] 127 | assert (arr[i] == ((i % 64) < 32) ? 1 : -1); | ^ [...]/libgomp.oacc-c-c++-common/mode-transitions.c: In function ‘t9’: [...]/libgomp.oacc-c-c++-common/mode-transitions.c:359:46: warning: ‘?:’ using integer constants in boolean context, the expression will always evaluate to ‘true’ [-Wint-in-bool-context] 359 | assert (arr[i] == ((i % 3) == 0) ? 1 : 2); | ^ ..., and PR101862 "[C, C++] Potential '?:' diagnostic for always-true expressions in boolean context". libgomp/ * testsuite/libgomp.oacc-c-c++-common/mode-transitions.c: Address '?:' issues. --- diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/mode-transitions.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/mode-transitions.c index 6c989abedf5c..94dc9d052933 100644 --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/mode-transitions.c +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/mode-transitions.c @@ -124,7 +124,7 @@ void t3() assert (n[i] == 2); for (i = 0; i < 1024; i++) - assert (arr[i] == ((i % 64) < 32) ? 1 : -1); + assert (arr[i] == (((i % 64) < 32) ? 1 : -1)); } @@ -356,7 +356,7 @@ void t9() } for (i = 0; i < 1024; i++) - assert (arr[i] == ((i % 3) == 0) ? 1 : 2); + assert (arr[i] == ((i % 3) == 0 ? 1 : 2)); } } @@ -960,7 +960,7 @@ void t23() } for (i = 0; i < 32; i++) - assert (arr[i] == ((i % 2) != 0) ? i + 1 : i + 2); + assert (arr[i] == (((i % 2) != 0) ? i + 1 : i + 2)); }