From: Taylor Blau Date: Thu, 23 Apr 2020 21:41:02 +0000 (-0600) Subject: commit-graph.c: don't use discarded graph_name in error X-Git-Tag: v2.27.0-rc0~59^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a2d57e22803b1da0df95b0a88a34116209eeb6e6;p=thirdparty%2Fgit.git commit-graph.c: don't use discarded graph_name in error When writing a commit-graph layer, we do so in a temporary file which is renamed into place. If we fail to create a temporary file, for e.g., because we have too many open files, then 'git_mkstemp_mode' sets the pattern to the empty string, in which case we get an error something along the lines of: error: unable to create '' It's not useful to show the pattern here at all, since we (1) know the pattern is well-formed, and (2) would have already shown the dirname when trying to create the leading directories. So, replace this error with something friendlier. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano --- diff --git a/commit-graph.c b/commit-graph.c index af677fc98e..98bbbbfc32 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -1397,7 +1397,7 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx) fd = git_mkstemp_mode(ctx->graph_name, 0444); if (fd < 0) { - error(_("unable to create '%s'"), ctx->graph_name); + error(_("unable to create temporary graph layer")); return -1; }