From: Tim Duesterhus <tim@bastelstu.be>
Date: Sun, 28 Feb 2021 15:12:20 +0000 (+0100)
Subject: BUG/MINOR: mux-h2: Fix typo in scheme adjustment
X-Git-Tag: v2.4-dev11~48
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a3298023b04923ba12429d79c559dc7a850ae122;p=thirdparty%2Fhaproxy.git

BUG/MINOR: mux-h2: Fix typo in scheme adjustment

That comma should've been a semicolon. Fortunately, as it is now there
is no impact thanks to operators precedence, and all expressions are
properly evaluated. But this is troubling and the risk is high to
turn it into an effective bug with a minor change.

Introduced in b8ce8905cf63ecd06b36af39c05103fadf3cc347 which first
appeared in 2.1-dev3. This fix must be backported to 2.1+.
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index 4bffd45259..4dada0b0c6 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -5361,7 +5361,7 @@ static size_t h2s_bck_make_req_headers(struct h2s *h2s, struct htx *htx)
 			if (len + 2 < uri.len && uri.ptr[len + 1] == '/' && uri.ptr[len + 2] == '/') {
 				/* make the uri start at the authority now */
 				scheme.ptr = uri.ptr;
-				scheme.len = len,
+				scheme.len = len;
 				uri.ptr += len + 3;
 				uri.len -= len + 3;