From: David Rowley <drowley@postgresql.org>
Date: Tue, 5 Mar 2024 03:17:02 +0000 (+1300)
Subject: Fix incorrectly reported stats kind in "can't happen" ERROR
X-Git-Tag: REL_17_BETA1~748
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=a37a3e2b36d7de965f974b8caca0c295833708f2;p=thirdparty%2Fpostgresql.git

Fix incorrectly reported stats kind in "can't happen" ERROR

The error message(s) were reporting the stats kind of 'f', which is not
correct as that's for the "dependencies" statistics kind.

Reported-by: Horst Reiterer
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/18375-ba99383eb9062d6a@postgresql.org
Backpatch-through: 12, where MCV extended stats were added.
---

diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c
index 749e99d53a4..5d7bdc9d12a 100644
--- a/src/backend/statistics/extended_stats.c
+++ b/src/backend/statistics/extended_stats.c
@@ -2440,7 +2440,7 @@ statext_expressions_load(Oid stxoid, bool inh, int idx)
 	if (isnull)
 		elog(ERROR,
 			 "requested statistics kind \"%c\" is not yet built for statistics object %u",
-			 STATS_EXT_DEPENDENCIES, stxoid);
+			 STATS_EXT_EXPRESSIONS, stxoid);
 
 	eah = DatumGetExpandedArray(value);
 
diff --git a/src/backend/statistics/mcv.c b/src/backend/statistics/mcv.c
index 2b5ad434f78..b0e9aead84e 100644
--- a/src/backend/statistics/mcv.c
+++ b/src/backend/statistics/mcv.c
@@ -572,7 +572,7 @@ statext_mcv_load(Oid mvoid, bool inh)
 	if (isnull)
 		elog(ERROR,
 			 "requested statistics kind \"%c\" is not yet built for statistics object %u",
-			 STATS_EXT_DEPENDENCIES, mvoid);
+			 STATS_EXT_MCV, mvoid);
 
 	result = statext_mcv_deserialize(DatumGetByteaP(mcvlist));